Chromium Code Reviews| Index: fpdfsdk/fsdk_rendercontext.cpp |
| diff --git a/fpdfsdk/fsdk_rendercontext.cpp b/fpdfsdk/fsdk_rendercontext.cpp |
| index eb630dd60fba32d25dc35e504f100ec3bd96c951..2862cb5abe0e245725b03b8faf5227284885c595 100644 |
| --- a/fpdfsdk/fsdk_rendercontext.cpp |
| +++ b/fpdfsdk/fsdk_rendercontext.cpp |
| @@ -15,10 +15,6 @@ void CRenderContext::Clear() { |
| m_pRenderer = NULL; |
| m_pAnnots = NULL; |
| m_pOptions = NULL; |
| -#ifdef _WIN32_WCE |
| - m_pBitmap = NULL; |
| - m_hBitmap = NULL; |
| -#endif |
| } |
| CRenderContext::~CRenderContext() { |
| @@ -28,11 +24,6 @@ CRenderContext::~CRenderContext() { |
| delete m_pAnnots; |
| delete m_pOptions->m_pOCContext; |
| delete m_pOptions; |
| -#ifdef _WIN32_WCE |
| - delete m_pBitmap; |
| - if (m_hBitmap) |
| - DeleteObject(m_hBitmap); |
| -#endif |
| } |
| IFSDK_PAUSE_Adapter::IFSDK_PAUSE_Adapter(IFSDK_PAUSE* IPause) { |
| @@ -42,8 +33,6 @@ IFSDK_PAUSE_Adapter::IFSDK_PAUSE_Adapter(IFSDK_PAUSE* IPause) { |
| IFSDK_PAUSE_Adapter::~IFSDK_PAUSE_Adapter() {} |
| FX_BOOL IFSDK_PAUSE_Adapter::NeedToPauseNow() { |
| - if (m_IPause->NeedToPauseNow) { |
| - return m_IPause->NeedToPauseNow(m_IPause); |
| - } |
| - return FALSE; |
| + auto* pPauseFunc = m_IPause->NeedToPauseNow; |
| + return pPauseFunc ? pPauseFunc(m_IPause) : FALSE; |
|
Tom Sepez
2016/05/26 23:03:33
nit: |? : FALSE| anti-pattern, lets see:
return p
Lei Zhang
2016/05/26 23:08:11
Done.
|
| } |