Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2011563006: Remove checks for _WIN32_WCE. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase, fix build, make FX_OpenFolder impls match #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -103 lines) Patch
M core/fxcrt/fx_basic_util.cpp View 1 3 chunks +18 lines, -37 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 chunks +0 lines, -45 lines 0 comments Download
M fpdfsdk/fsdk_rendercontext.cpp View 1 2 3 chunks +1 line, -13 lines 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/fpdfview.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Lei Zhang
4 years, 6 months ago (2016-05-26 22:50:17 UTC) #2
Lei Zhang
BTW, there are a few more in third_party, but I didn't bother with them.
4 years, 6 months ago (2016-05-26 22:53:51 UTC) #3
Tom Sepez
lgtm Yeah, lets not mess with 3rd party. https://codereview.chromium.org/2011563006/diff/20001/fpdfsdk/fsdk_rendercontext.cpp File fpdfsdk/fsdk_rendercontext.cpp (right): https://codereview.chromium.org/2011563006/diff/20001/fpdfsdk/fsdk_rendercontext.cpp#newcode37 fpdfsdk/fsdk_rendercontext.cpp:37: return ...
4 years, 6 months ago (2016-05-26 23:03:33 UTC) #4
Lei Zhang
https://codereview.chromium.org/2011563006/diff/20001/fpdfsdk/fsdk_rendercontext.cpp File fpdfsdk/fsdk_rendercontext.cpp (right): https://codereview.chromium.org/2011563006/diff/20001/fpdfsdk/fsdk_rendercontext.cpp#newcode37 fpdfsdk/fsdk_rendercontext.cpp:37: return pPauseFunc ? pPauseFunc(m_IPause) : FALSE; On 2016/05/26 23:03:33, ...
4 years, 6 months ago (2016-05-26 23:08:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011563006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011563006/40001
4 years, 6 months ago (2016-05-26 23:08:21 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 23:33:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/3bd3841291b46bd7ae31cfb8dc8035e5b4ed...

Powered by Google App Engine
This is Rietveld 408576698