Complete or comment a couple Script_NodeClass functions

Complete or comment a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Complete or comment two functions in this change list.
The implementation follows Adobe's XFA 2.1 references here:
http://help.adobe.com/en_US/livecycle/9.0/designerHelp/index.htm?content=001363.html.

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29
Committed: https://pdfium.googlesource.com/pdfium/+/65be4b1818ab99df2bf5b6265604fc25456db49d

[Wei Li, 2016-05-25 17:14:59]

Description was changed from

==========
Comment or complete a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Comment or complete two functions in this change list.

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29
==========

to

==========
Complete or comment a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Complete or comment two functions in this change list.

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29
==========

[Wei Li, 2016-05-25 17:17:04]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[Wei Li, 2016-05-25 17:17:04]

pls review, thanks

[dsinclair, 2016-05-25 17:42:38]

lgtm

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
File xfa/fxfa/parser/xfa_object_imp.cpp (right):

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:1119: // warning.
Should we file a bug for this and link here?

[Tom Sepez, 2016-05-25 17:50:29]

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
File xfa/fxfa/parser/xfa_object_imp.cpp (right):

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:917: if (iLength >= 1)
nit {} needed because of line break in next stmt.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:921: bParent = pArguments->GetInt32(1) ? TRUE
: FALSE;
nit: prefer !!pArguments->GetInt32(1);

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:933: bHas = GetProperty(iIndex,
pElementInfo->eName) != nullptr;
nit: again !! might be cleaner.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:934: if (!bHas && bParent && m_pParent) {
Where did the idea for this addition come from?  Can we talk about it in more
detail in the change description.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:938: bHas = m_pParent->GetProperty(iIndex,
pElementInfo->eName) != nullptr;
nit and here.

[Wei Li, 2016-05-25 18:07:23]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-05-25 18:11:46]

Description was changed from

==========
Complete or comment a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Complete or comment two functions in this change list.

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29
==========

to

==========
Complete or comment a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Complete or comment two functions in this change list. The
implementation follows Adobe's XFA 2.1 references here
http://help.adobe.com/en_US/livecycle/9.0/designerHelp/index.htm?content=0013....

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29
==========

[Wei Li, 2016-05-25 18:12:18]

Description was changed from

==========
Complete or comment a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Complete or comment two functions in this change list. The
implementation follows Adobe's XFA 2.1 references here
http://help.adobe.com/en_US/livecycle/9.0/designerHelp/index.htm?content=0013....

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29
==========

to

==========
Complete or comment a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Complete or comment two functions in this change list.
The implementation follows Adobe's XFA 2.1 references here:
http://help.adobe.com/en_US/livecycle/9.0/designerHelp/index.htm?content=0013....

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29
==========

[Wei Li, 2016-05-25 18:13:19]

Updated, thanks.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
File xfa/fxfa/parser/xfa_object_imp.cpp (right):

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:917: if (iLength >= 1)
On 2016/05/25 17:50:29, Tom Sepez wrote:
> nit {} needed because of line break in next stmt.

Done.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:921: bParent = pArguments->GetInt32(1) ? TRUE
: FALSE;
On 2016/05/25 17:50:29, Tom Sepez wrote:
> nit: prefer !!pArguments->GetInt32(1);

Done.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:933: bHas = GetProperty(iIndex,
pElementInfo->eName) != nullptr;
On 2016/05/25 17:50:29, Tom Sepez wrote:
> nit: again !! might be cleaner.

Done.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:934: if (!bHas && bParent && m_pParent) {
On 2016/05/25 17:50:29, Tom Sepez wrote:
> Where did the idea for this addition come from?  Can we talk about it in more
> detail in the change description.

Done.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:938: bHas = m_pParent->GetProperty(iIndex,
pElementInfo->eName) != nullptr;
On 2016/05/25 17:50:29, Tom Sepez wrote:
> nit and here.

Done.

https://codereview.chromium.org/2011553004/diff/1/xfa/fxfa/parser/xfa_object_...
xfa/fxfa/parser/xfa_object_imp.cpp:1119: // warning.
On 2016/05/25 17:42:38, dsinclair wrote:
> Should we file a bug for this and link here?

Done.

[Tom Sepez, 2016-05-25 22:17:52]

lgtm

[Wei Li, 2016-05-25 22:38:04]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-05-25 22:38:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2011553004/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-25 22:38:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011553004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011553004/40001

[commit-bot: I haz the power, 2016-05-25 22:47:47]

Description was changed from

==========
Complete or comment a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Complete or comment two functions in this change list.
The implementation follows Adobe's XFA 2.1 references here:
http://help.adobe.com/en_US/livecycle/9.0/designerHelp/index.htm?content=0013....

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29
==========

to

==========
Complete or comment a couple Script_NodeClass functions

There are a few functions which are not completed in
CXFA_Node class. Complete or comment two functions in this change list.
The implementation follows Adobe's XFA 2.1 references here:
http://help.adobe.com/en_US/livecycle/9.0/designerHelp/index.htm?content=0013....

Also, remove a data structure no longer needed -- the code which used it
has been removed.

BUG=pdfium:29

Committed:
https://pdfium.googlesource.com/pdfium/+/65be4b1818ab99df2bf5b6265604fc25456d...
==========

[commit-bot: I haz the power, 2016-05-25 22:47:49]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/65be4b1818ab99df2bf5b6265604fc25456d...