Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2011553003: Revert of [Binding] Add [OverrideBuiltins] label onto HTMLDocument interface (Closed)

Created:
4 years, 7 months ago by peria
Modified:
4 years, 7 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Binding] Add [OverrideBuiltins] label onto HTMLDocument interface (patchset #3 id:460001 of https://codereview.chromium.org/1837823003/ ) Reason for revert: performance regression BUG=614559 Original issue's description: > Add [OverrideBuiltins] label onto HTMLDocument interface. > > This CL also removes special handling of named properties > using V8 script controller, which is no longer needed. > > Currently, we have no general routines to work for [Unforgeable] > on [OverrideBuiltins] interface, and "location" in "HTMLDocument" > is the only one which meets the situation. > So now, we handle it as an edge case of named property. > > Spec: https://html.spec.whatwg.org/multipage/dom.html#dom-document-namedItem-which > > Updated a test expectation; Chrome has been FAILing it, while IE, FF, and Safari PASS it. > > BUG=611632 > > Committed: https://crrev.com/09649cf329fd0644f50624b80f6a2f9c564dcb2d > Cr-Commit-Position: refs/heads/master@{#395570} TBR=haraken@chromium.org,yukishiino@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611632 Committed: https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5 Cr-Commit-Position: refs/heads/master@{#395824}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
peria
Created Revert of [Binding] Add [OverrideBuiltins] label onto HTMLDocument interface
4 years, 7 months ago (2016-05-25 07:29:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011553003/1
4 years, 7 months ago (2016-05-25 07:29:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 07:30:21 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5 Cr-Commit-Position: refs/heads/master@{#395824}
4 years, 7 months ago (2016-05-25 07:31:50 UTC) #6
haraken
4 years, 7 months ago (2016-05-25 07:51:51 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698