Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: runtime/include/dart_api.h

Issue 2011543002: Canonicalize uris in C++ instead of Dart for the standalone embedder. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index bc8c474ddc275e2963a38b7eec41b81752fc5149..c211559214cecf4e1698f2dbd395a0f8e14b201c 100755
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -2684,15 +2684,34 @@ DART_EXPORT Dart_Handle Dart_SetLibraryTagHandler(
Dart_LibraryTagHandler handler);
/**
+ * Canonicalizes a url with respect to some library.
+ *
+ * The url is resolved with respect to the library's url and some url
+ * normalizations are performed.
+ *
+ * This canonicalization function should be sufficient for most
+ * embedders to implement the Dart_kCanonicalizeUrl tag.
+ *
+ * \param library The library relative to which the url is being
+ * resolved.
ahe 2016/05/25 12:44:52 Consider documenting what the Dart type of library
turnidge 2016/05/31 18:25:27 Documented that url is a string handle. The docum
+ * \param url The url being resolved and canonicalized.
+ *
+ * \return If no error occurs, a String object is returned. Otherwise
+ * an error handle is returned.
+ */
+DART_EXPORT Dart_Handle Dart_DefaultCanonicalizeUrl(Dart_Handle library,
Cutch 2016/05/24 23:53:46 If we had another variant of this API call that to
turnidge 2016/05/31 18:25:27 Responded on other comment.
+ Dart_Handle url);
+
+/**
* Loads the root script for the current isolate. The script can be
* embedded in another file, for example in an html file.
*
* TODO(turnidge): Document.
*
- * \line_offset is the number of text lines before the
+ * \param line_offset is the number of text lines before the
* first line of the Dart script in the containing file.
*
- * \col_offset is the number of characters before the first character
+ * \param col_offset is the number of characters before the first character
* in the first line of the Dart script.
*/
DART_EXPORT Dart_Handle Dart_LoadScript(Dart_Handle url,

Powered by Google App Engine
This is Rietveld 408576698