Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 201153013: Revert 169395 "Set geometry dirty bits on composited layer mappi..." (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo
Modified:
6 years, 9 months ago
Reviewers:
chrishtr
CC:
blink-reviews
Visibility:
Public.

Description

Revert 169395 "Set geometry dirty bits on composited layer mappi..." Causing virtual/softwarecompositing/squashing/squashed-layer-loses-graphicslayer.html to fail. > Set geometry dirty bits on composited layer mappings when updating squashed layers. > > The lack of setting geometry dirty bits in these cases is wrong. However, at the moment it is masked by setting needs geometry dirty bits more globally upwards in the system. When that is cleaned up these targeted ones will be in place. > > BUG= > > Review URL: https://codereview.chromium.org/200623006 TBR=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -85 lines) Patch
D trunk/LayoutTests/compositing/squashing/squashed-layer-color-update.html View 1 chunk +0 lines, -45 lines 0 comments Download
D trunk/LayoutTests/compositing/squashing/squashed-layer-color-update-expected.html View 1 chunk +0 lines, -29 lines 0 comments Download
M trunk/Source/core/rendering/RenderLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Zhenyao Mo
6 years, 9 months ago (2014-03-18 01:24:49 UTC) #1
Zhenyao Mo
Committed patchset #1 manually as r169402.
6 years, 9 months ago (2014-03-18 01:25:48 UTC) #2
chrishtr
6 years, 9 months ago (2014-03-19 18:25:22 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698