Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 201153008: Fix RenderBlock::percentHeightDescendants() (Closed)

Created:
6 years, 9 months ago by Xianzhu
Modified:
6 years, 9 months ago
Reviewers:
pdr., esprehn, ojan
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., kouhei+svg_chromium.org, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Fix RenderBlock::percentHeightDescendants() RenderBlock::percentHeightDescendants() is used to schedule layout of descencents of a block when the logical height of the block changes. It should contain descendants having percent height whose real height calculation depends on the height of the block. Previously - the set doesn't contain direct children; - skipped containing blocks for percent height calculation unnecessarily have the set. Let the set contain all necessary objects. This doesn't fix any functional breakage for now, but later layout optimization may depend on the correct behavior of the function. BUG=327815 TEST=WebFrameTest.RenderBlockPercentHeightDescendants Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M Source/core/rendering/RenderBlock.h View 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
A Source/web/tests/data/percent-height-descendants.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Xianzhu
This CL is split from https://codereview.chromium.org/190973007/ which needs more thinking.
6 years, 9 months ago (2014-03-17 21:54:39 UTC) #1
ojan
lgtm
6 years, 9 months ago (2014-03-19 20:06:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/201153008/1
6 years, 9 months ago (2014-03-19 20:06:04 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 21:21:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-19 21:21:45 UTC) #5
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-19 21:35:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/201153008/1
6 years, 9 months ago (2014-03-19 21:36:34 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 22:51:32 UTC) #8
Message was sent while issue was closed.
Change committed as 169588

Powered by Google App Engine
This is Rietveld 408576698