Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2011483002: [build] Enable -Wformat-pedantic compiler warning (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Enable -Wformat-pedantic compiler warning For cross-compiler-compatibility and standards compliance %p requires a void*, rather than any pointer type. This was fixed in: https://codereview.chromium.org/2001073002/ BUG=chromium:474921 Committed: https://crrev.com/db5246fadf5d3d9714a224fe7dff0ed3cfbbcdcf Cr-Commit-Position: refs/heads/master@{#36473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M gypfiles/standalone.gypi View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011483002/1
4 years, 7 months ago (2016-05-24 11:49:08 UTC) #4
Michael Achenbach
PTAL. Switching on the warning after fixes have landed.
4 years, 7 months ago (2016-05-24 11:49:18 UTC) #5
vogelheim
lgtm
4 years, 7 months ago (2016-05-24 11:57:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011483002/1
4 years, 7 months ago (2016-05-24 12:00:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 12:22:42 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 12:23:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db5246fadf5d3d9714a224fe7dff0ed3cfbbcdcf
Cr-Commit-Position: refs/heads/master@{#36473}

Powered by Google App Engine
This is Rietveld 408576698