Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2011473003: Add OpenGL support to Linux viewer (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add OpenGL support to Linux viewer Also adds a command line option (--vulkan) to choose between Vulkan and OpenGL. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2011473003 Committed: https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c Committed: https://skia.googlesource.com/skia/+/85f758c33446eaccfadc12292fa5a0e71d7661b9

Patch Set 1 #

Patch Set 2 : Fix onIdle #

Patch Set 3 : Rebase to ToT #

Patch Set 4 : Add a little window cleanup #

Patch Set 5 : Fix patch #

Patch Set 6 : Repatched the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -34 lines) Patch
M tools/viewer/Viewer.cpp View 1 5 5 chunks +9 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/viewer/sk_app/Window.cpp View 5 1 chunk +1 line, -0 lines 0 comments Download
M tools/viewer/sk_app/unix/VulkanWindowContext_unix.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/unix/Window_unix.h View 1 2 3 4 chunks +20 lines, -9 lines 0 comments Download
M tools/viewer/sk_app/unix/Window_unix.cpp View 1 2 3 7 chunks +107 lines, -21 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
jvanverth1
4 years, 7 months ago (2016-05-26 14:40:23 UTC) #3
jvanverth1
Adding brianosman@ to make sure the XVisualInfo setup is okay.
4 years, 7 months ago (2016-05-26 20:19:08 UTC) #5
bsalomon
rs lgtm
4 years, 7 months ago (2016-05-26 20:23:08 UTC) #6
Brian Osman
lgtm - If I ever figure out how to get 10-bit color working in X ...
4 years, 7 months ago (2016-05-26 20:29:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011473003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011473003/60001
4 years, 7 months ago (2016-05-26 21:07:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/9979)
4 years, 7 months ago (2016-05-26 21:09:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011473003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011473003/80001
4 years, 6 months ago (2016-05-27 12:30:11 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/10b3815a11c39b154ec7b74a2af43e019b50d48c
4 years, 6 months ago (2016-05-27 12:47:03 UTC) #16
kjlubick
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2015213002/ by kjlubick@google.com. ...
4 years, 6 months ago (2016-05-27 13:20:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011473003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011473003/100001
4 years, 6 months ago (2016-05-27 13:32:34 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 13:47:12 UTC) #23
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/85f758c33446eaccfadc12292fa5a0e71d7661b9

Powered by Google App Engine
This is Rietveld 408576698