Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2011453002: Mark some AwContentsClientFullScreenTest tests flaky. (Closed)

Created:
4 years, 7 months ago by Michael van Ouwerkerk
Modified:
4 years, 6 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark some AwContentsClientFullScreenTest tests flaky. BUG=614318 Committed: https://crrev.com/22a7f8467da532e4ab9f07256de4a11e93888341 Cr-Commit-Position: refs/heads/master@{#395588}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java View 1 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Michael van Ouwerkerk
4 years, 7 months ago (2016-05-24 10:49:29 UTC) #2
Torne
lgtm
4 years, 7 months ago (2016-05-24 12:56:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011453002/20001
4 years, 7 months ago (2016-05-24 13:00:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 13:34:29 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/22a7f8467da532e4ab9f07256de4a11e93888341 Cr-Commit-Position: refs/heads/master@{#395588}
4 years, 7 months ago (2016-05-24 13:36:36 UTC) #8
boliu
So... it's not obvious, but this was not really correct I asked jbudorick, @FlakyTest in ...
4 years, 6 months ago (2016-06-03 22:44:42 UTC) #9
boliu
I'm... actually gonna just revert this. Maybe tests have recovered now..
4 years, 6 months ago (2016-06-03 22:59:39 UTC) #10
boliu
4 years, 6 months ago (2016-06-03 23:00:12 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2039463004/ by boliu@chromium.org.

The reason for reverting is: Avoid disabling these tests on CQ.

Powered by Google App Engine
This is Rietveld 408576698