ECDSA default certificate in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

ECDSA default certificate in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698
Committed: https://crrev.com/bd0f07eb0c705b800aa424ef9feef11b7181aa7e
Cr-Commit-Position: refs/heads/master@{#396156}

[hbos_chromium, 2016-05-24 16:56:33]

Patchset #1 (id:1) has been deleted

[hbos_chromium, 2016-05-24 16:56:53]

The CQ bit was checked by hbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 16:57:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011443002/20001

[hbos_chromium, 2016-05-24 17:29:48]

Description was changed from

==========
Make ECDSA default cert in WebRTC (remove experiment flag kWebRtcEcdsaDefault).

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698
==========

to

==========
ECDSA default cert in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698
==========

[hbos_chromium, 2016-05-24 17:30:08]

Description was changed from

==========
ECDSA default cert in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698
==========

to

==========
ECDSA default certificate in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698
==========

[commit-bot: I haz the power, 2016-05-24 18:35:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 18:35:36]

Dry run: This issue passed the CQ dry run.

[hbos_chromium, 2016-05-24 18:37:00]

hbos@chromium.org changed reviewers:
+ nick@chromium.org, tommi@chromium.org

[hbos_chromium, 2016-05-24 18:37:01]

Please take a look, nick and tommi.

[tommi (sloooow) - chröme, 2016-05-24 20:58:11]

lgtm

https://codereview.chromium.org/2011443002/diff/20001/content/renderer/media/...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/2011443002/diff/20001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:727: if (rtc::KT_DEFAULT
!= rtc::KT_ECDSA && config->certificates.empty()) {
do we still need this or do you plan on removing this after a webrtc roll?

[hbos_chromium, 2016-05-25 07:58:35]

Please take a look, ncarter.

https://codereview.chromium.org/2011443002/diff/20001/content/renderer/media/...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/2011443002/diff/20001/content/renderer/media/...
content/renderer/media/rtc_peer_connection_handler.cc:727: if (rtc::KT_DEFAULT
!= rtc::KT_ECDSA && config->certificates.empty()) {
On 2016/05/24 20:58:11, tommi-chrömium wrote:
> do we still need this or do you plan on removing this after a webrtc roll?

Since this CL removes a static_assert about KT_DEFAULT == KT_RSA it has to land
before the webrtc change that makes KT_DEFAULT == KT_ECDSA. After this has
landed and webrtc has rolled I'll remove OverrideDefaultCertificate.

[ncarter (slow), 2016-05-25 18:22:24]

lgtm

[hbos_chromium, 2016-05-26 08:30:12]

The CQ bit was checked by hbos@chromium.org

[commit-bot: I haz the power, 2016-05-26 08:30:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011443002/20001

[commit-bot: I haz the power, 2016-05-26 10:56:00]

Description was changed from

==========
ECDSA default certificate in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698
==========

to

==========
ECDSA default certificate in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698
==========

[commit-bot: I haz the power, 2016-05-26 10:56:01]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-05-26 10:57:47]

Description was changed from

==========
ECDSA default certificate in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698
==========

to

==========
ECDSA default certificate in WebRTC: Remove experiment flag kWebRtcEcdsaDefault.

The experiment behind this flag ends in M52. The flag has already been defaulted
to true. This removes the flag and makes ECDSA the default certificate
unconditionally.

BUG=601850, 611698

Committed: https://crrev.com/bd0f07eb0c705b800aa424ef9feef11b7181aa7e
Cr-Commit-Position: refs/heads/master@{#396156}
==========

[commit-bot: I haz the power, 2016-05-26 10:57:49]

Patchset 1 (id:??) landed as
https://crrev.com/bd0f07eb0c705b800aa424ef9feef11b7181aa7e
Cr-Commit-Position: refs/heads/master@{#396156}