[Hera] Excise a bunch of document mode code

[Hera] Excise a bunch of document mode code

Deprecated document mode code is hindering efforts to refactor
other classes.  Excise as much DocumentActivity related code
as possible in one swoop so that it's easy to find later, if
for some reason it's needed.

* Force all users entering DocumentActivity through the migration
  pathway without checking if they're in document mode.  There
  should be no valid way to trigger a DocumentActivity, short of
  being inside Recents when migration is completed and reselecting
  an old Document tab.

* Delete practically everything inside the DocumentActivity class
  to make it easier to determine dead dependencies in classes that
  are being refactored.

* Delete all DocumentActivity-launching related functions from
  ChromeLauncherActivity, and things that spiral out from there.

* Delete most of the document mode tests.

* Deletes a bunch of DocumentTabModel related code.  Migration
  pathways still seem to be intact.

BUG=582539
Committed: https://crrev.com/35eb7ce0cd77f420076b796bb50a96c4958992ff
Cr-Commit-Position: refs/heads/master@{#396062}

[gone, 2016-05-25 01:27:11]

dfalcantara@chromium.org changed reviewers:
+ tedchoc@chromium.org

[gone, 2016-05-25 01:27:11]

Hacking off the easier bits first.  Should make it easier to chop up the
DocumentTabModel once these dependencies are cleared out.

[gone, 2016-05-25 16:07:21]

Hmm.  DocumentTabModelImpl tests are failing.  Guess I should excise those in
this patch, too, then.

[gone, 2016-05-25 16:23:43]

Er, looks like a @VisibleForTesting problem.  Just going to add that annotation
where necessary and nuke the DocumentTabModelImpl later.

[gone, 2016-05-25 17:21:09]

Description was changed from

==========
[Hera] Excise a bunch of document mode code

Deprecated document mode code is hindering efforts to refactor
other classes.  Excise as much DocumentActivity related code
as possible in one swoop so that it's easy to find later, if
for some reason it's needed.

* Force all users entering DocumentActivity through the migration
  pathway without checking if they're in document mode.  There
  should be no valid way to trigger a DocumentActivity, short of
  being inside Recents when migration is completed and reselecting
  an old Document tab.

* Delete practically everything inside the DocumentActivity class
  to make it easier to determine dead dependencies in classes that
  are being refactored.

* Delete all DocumentActivity-launching related functions from
  ChromeLauncherActivity, and things that spiral out from there.

* Delete most of the document mode tests.

- Doesn't touch the DocumentTabModel-related classes, yet.
  That will require more surgical precision instead of a cleaver
  to avoid messing up the migration pathways.

BUG=582539
==========

to

==========
[Hera] Excise a bunch of document mode code

Deprecated document mode code is hindering efforts to refactor
other classes.  Excise as much DocumentActivity related code
as possible in one swoop so that it's easy to find later, if
for some reason it's needed.

* Force all users entering DocumentActivity through the migration
  pathway without checking if they're in document mode.  There
  should be no valid way to trigger a DocumentActivity, short of
  being inside Recents when migration is completed and reselecting
  an old Document tab.

* Delete practically everything inside the DocumentActivity class
  to make it easier to determine dead dependencies in classes that
  are being refactored.

* Delete all DocumentActivity-launching related functions from
  ChromeLauncherActivity, and things that spiral out from there.

* Delete most of the document mode tests.

* Deletes a bunch of DocumentTabModel related code.  Migration
  pathways still seem to be intact.

BUG=582539
==========

[gone, 2016-05-25 17:22:41]

Ended up combining the follow up CL to nullify the DocumentTabModel in this one
as Patch set 3.  Patch set 2 shows what happens if we just delete
DocumentActivity.  Don't know which one is more preferable, but having fewer CLs
makes it easier to find things later.

[gone, 2016-05-25 18:07:20]

+Peter as a heads up.

[Ted C, 2016-05-25 18:26:59]

Should we be marking metrics as deprecated as well?  Looks like we removed some
stuff here.

https://codereview.chromium.org/2011433003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://codereview.chromium.org/2011433003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:206:
if (!mIsCustomTabIntent && !FeatureUtilities.isDocumentMode(this)) {
is this DocumentMode check here to support migration?

https://codereview.chromium.org/2011433003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:214:
if (launchFirstRunExperience()) {
hmm...do we need this check anymore?

do we show FRE if someone sends us a custom tab intent?  Looking at the code it
looks like we do, so I guess this is fine to keep.

https://codereview.chromium.org/2011433003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/document/IncognitoDocumentActivity.java
(right):

https://codereview.chromium.org/2011433003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/document/IncognitoDocumentActivity.java:8:
* Deprecated, but kept around because it was exported in Chrome's Manifest.
should we just create an activity alias instead of keeping the class around? 
more confusing?

[gone, 2016-05-25 20:22:20]

You cool with deprecating the histograms in a follow up?

https://chromiumcodereview.appspot.com/2011433003/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
(right):

https://chromiumcodereview.appspot.com/2011433003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:206:
if (!mIsCustomTabIntent && !FeatureUtilities.isDocumentMode(this)) {
On 2016/05/25 18:26:58, Ted C wrote:
> is this DocumentMode check here to support migration?

Yeah, it'll fall through to the migration pathway below.

https://chromiumcodereview.appspot.com/2011433003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java:214:
if (launchFirstRunExperience()) {
On 2016/05/25 18:26:58, Ted C wrote:
> hmm...do we need this check anymore?
> 
> do we show FRE if someone sends us a custom tab intent?  Looking at the code
it
> looks like we do, so I guess this is fine to keep.

Yeah, I think we do.

https://chromiumcodereview.appspot.com/2011433003/diff/60001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/document/IncognitoDocumentActivity.java
(right):

https://chromiumcodereview.appspot.com/2011433003/diff/60001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/document/IncognitoDocumentActivity.java:8:
* Deprecated, but kept around because it was exported in Chrome's Manifest.
On 2016/05/25 18:26:58, Ted C wrote:
> should we just create an activity alias instead of keeping the class around? 
> more confusing?

Tried to do that, but we need the IncognitoDocumentActivity.class to create the
DocumentModeAssassin's ActivityDelegate.

[gone, 2016-05-25 20:31:38]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 20:32:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011433003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011433003/60001

[commit-bot: I haz the power, 2016-05-25 20:58:55]

Dry run: None

[gone, 2016-05-25 21:01:25]

dfalcantara@chromium.org changed reviewers:
+ isherman@chromium.org

[gone, 2016-05-25 21:01:26]

+isherman for histograms deprecation

[Ted C, 2016-05-25 22:29:17]

lgtm

[Ilya Sherman, 2016-05-25 22:32:33]

histograms.xml lgtm

[gone, 2016-05-25 22:36:01]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-05-25 22:37:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011433003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011433003/80001

[commit-bot: I haz the power, 2016-05-26 01:00:19]

Description was changed from

==========
[Hera] Excise a bunch of document mode code

Deprecated document mode code is hindering efforts to refactor
other classes.  Excise as much DocumentActivity related code
as possible in one swoop so that it's easy to find later, if
for some reason it's needed.

* Force all users entering DocumentActivity through the migration
  pathway without checking if they're in document mode.  There
  should be no valid way to trigger a DocumentActivity, short of
  being inside Recents when migration is completed and reselecting
  an old Document tab.

* Delete practically everything inside the DocumentActivity class
  to make it easier to determine dead dependencies in classes that
  are being refactored.

* Delete all DocumentActivity-launching related functions from
  ChromeLauncherActivity, and things that spiral out from there.

* Delete most of the document mode tests.

* Deletes a bunch of DocumentTabModel related code.  Migration
  pathways still seem to be intact.

BUG=582539
==========

to

==========
[Hera] Excise a bunch of document mode code

Deprecated document mode code is hindering efforts to refactor
other classes.  Excise as much DocumentActivity related code
as possible in one swoop so that it's easy to find later, if
for some reason it's needed.

* Force all users entering DocumentActivity through the migration
  pathway without checking if they're in document mode.  There
  should be no valid way to trigger a DocumentActivity, short of
  being inside Recents when migration is completed and reselecting
  an old Document tab.

* Delete practically everything inside the DocumentActivity class
  to make it easier to determine dead dependencies in classes that
  are being refactored.

* Delete all DocumentActivity-launching related functions from
  ChromeLauncherActivity, and things that spiral out from there.

* Delete most of the document mode tests.

* Deletes a bunch of DocumentTabModel related code.  Migration
  pathways still seem to be intact.

BUG=582539
==========

[commit-bot: I haz the power, 2016-05-26 01:00:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-26 01:01:32]

Description was changed from

==========
[Hera] Excise a bunch of document mode code

Deprecated document mode code is hindering efforts to refactor
other classes.  Excise as much DocumentActivity related code
as possible in one swoop so that it's easy to find later, if
for some reason it's needed.

* Force all users entering DocumentActivity through the migration
  pathway without checking if they're in document mode.  There
  should be no valid way to trigger a DocumentActivity, short of
  being inside Recents when migration is completed and reselecting
  an old Document tab.

* Delete practically everything inside the DocumentActivity class
  to make it easier to determine dead dependencies in classes that
  are being refactored.

* Delete all DocumentActivity-launching related functions from
  ChromeLauncherActivity, and things that spiral out from there.

* Delete most of the document mode tests.

* Deletes a bunch of DocumentTabModel related code.  Migration
  pathways still seem to be intact.

BUG=582539
==========

to

==========
[Hera] Excise a bunch of document mode code

Deprecated document mode code is hindering efforts to refactor
other classes.  Excise as much DocumentActivity related code
as possible in one swoop so that it's easy to find later, if
for some reason it's needed.

* Force all users entering DocumentActivity through the migration
  pathway without checking if they're in document mode.  There
  should be no valid way to trigger a DocumentActivity, short of
  being inside Recents when migration is completed and reselecting
  an old Document tab.

* Delete practically everything inside the DocumentActivity class
  to make it easier to determine dead dependencies in classes that
  are being refactored.

* Delete all DocumentActivity-launching related functions from
  ChromeLauncherActivity, and things that spiral out from there.

* Delete most of the document mode tests.

* Deletes a bunch of DocumentTabModel related code.  Migration
  pathways still seem to be intact.

BUG=582539

Committed: https://crrev.com/35eb7ce0cd77f420076b796bb50a96c4958992ff
Cr-Commit-Position: refs/heads/master@{#396062}
==========

[commit-bot: I haz the power, 2016-05-26 01:01:34]

Patchset 5 (id:??) landed as
https://crrev.com/35eb7ce0cd77f420076b796bb50a96c4958992ff
Cr-Commit-Position: refs/heads/master@{#396062}