Chromium Code Reviews| Index: tracing/bin/validate_all_metrics |
| diff --git a/tracing/bin/validate_all_metrics b/tracing/bin/validate_all_metrics |
| index 5cadeba2f59518c421d6398b80e382748d45040a..4711c5590f8778900f86182191c4cd72bdb0bbdf 100755 |
| --- a/tracing/bin/validate_all_metrics |
| +++ b/tracing/bin/validate_all_metrics |
| @@ -6,6 +6,7 @@ |
| import argparse |
| import json |
| import os |
| +import string |
| import sys |
| sys.path.insert(1, os.path.join(os.path.dirname(__file__), '..')) |
| @@ -26,8 +27,15 @@ def Main(): |
| 'tracing/tracing/metrics/all_metrics.html' % |
| ', '.join(unregistered_metrics)) |
| return 1 |
| - else: |
| - return 0 |
| + uppercased_metrics = [] |
| + for m in all_possible_metrics: |
| + if str.isupper(m[0]): |
| + uppercased_metrics.append(m) |
| + if uppercased_metrics: |
| + print ('These metrics must be renamed to start with a lower-case: %s' % |
| + uppercased_metrics) |
| + return 1 |
| + return 0 |
| if __name__ == '__main__': |
| sys.exit(Main()) |
|
nednguyen
2016/05/27 19:52:00
Note that this script is run by tracing/PRESUBMIT.
|