LayoutTests/http/tests/media/media-source/mediasource-play-then-seek-back.html - Issue 20114005: Layout Test for basic MSE seek scenario.

Side by Side Diff: LayoutTests/http/tests/media/media-source/mediasource-play-then-seek-back.html

Issue 20114005: Layout Test for basic MSE seek scenario. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="/w3c/resources/testharness.js"></script>

	5 <script src="/w3c/resources/testharnessreport.js"></script>

	6 <script src="mediasource-util.js"></script>

	7 <script src="/media/resources/media-source/webm/segment-info.js"></scrip t>

	8 <link rel='stylesheet' href='/w3c/resources/testharness.css'>

	9 </head>

	10 <body>

	11 <div id="log"></div>

	12 <script>

	13 var segmentInfo = WebMSegmentInfo.testWebM;

	14

	15 function seekBackAfterPlayingTest(callback, description)

	16 {

	17 mediasource_test(function(test, mediaElement, mediaSource)

	18 {

	19 var sourceBuffer = mediaSource.addSourceBuffer(segmentInfo.typ e);

	20 MediaSourceUtil.loadBinaryData(test, segmentInfo.url, function (mediaData)

	21 {

	22 callback(test, mediaElement, mediaSource, sourceBuffer, me diaData);

	23 });

	24 }, description, {timeout: 10000} );

	25 }

	26

	27 seekBackAfterPlayingTest(function(test, mediaElement, mediaSource, sou rceBuffer, mediaData)

	28 {

	29 test.failOnEvent(mediaElement, 'error');

	30

	31 mediaElement.play();

	32

	33 // Append all media segments.

	34 // Expect playing and timeupdate events.

	35 test.expectEvent(mediaElement, "playing", "Playing triggered");
	wolenetz 2013/07/24 23:16:43 style nit: prefer ' over " in js (multiple places style nit: prefer ' over " in js (multiple places in this file) anandc 2013/07/25 22:48:00 Done. Show quoted text On 2013/07/24 23:16:43, wolenetz wrote: > style nit: prefer ' over " in js (multiple places in this file) Done.
	36 test.expectEvent(mediaElement, "timeupdate", "timeupdate fired.");

	37 sourceBuffer.appendBuffer(mediaData);

	38

	39 test.waitForExpectedEvents(function()

	40 {

	41 if (mediaElement.currentTime > 0.5 ) {
	wolenetz 2013/07/24 23:16:43 style nit: 4-space indent (multiple places in this style nit: 4-space indent (multiple places in this file) anandc 2013/07/25 22:48:00 Done. Show quoted text On 2013/07/24 23:16:43, wolenetz wrote: > style nit: 4-space indent (multiple places in this file) Done.
	42 assert_greater_than(mediaElement.currentTime, 0.1);
	wolenetz 2013/07/24 23:16:43 Why are we asserting within a conditional that alr Why are we asserting within a conditional that already guarantees this (unless maybe currentTime is decreasing between the two queries??) anandc 2013/07/25 22:48:00 Yes, that was pretty stupid. :-) Gone. Show quoted text On 2013/07/24 23:16:43, wolenetz wrote: > Why are we asserting within a conditional that already guarantees this (unless > maybe currentTime is decreasing between the two queries??) Yes, that was pretty stupid. :-) Gone.
	43 assert_true(mediaElement.playing, "mediaElement is playing");

	44 // Seek back to 0.0

	45 test.expectEvent(mediaElement, "seeking", "mediaElement");

	46 test.expectEvent(mediaElement, "seeked", "mediaElement finishe d seek");
	wolenetz 2013/07/24 23:16:43 You'll need a 'timeupdate' expectation between 'se You'll need a 'timeupdate' expectation between 'seeking' and 'seeked', and it would be good to confirm on receipt of this specific 'timeupdate' that seeking is true and currentTime is the expected seek target (0.0). Note also that some implementations may already have expired already played data in buffers, and may also issue 'waiting' between 'seeking' and 'timeupdate' and also 'playing', though I'm not exactly clear in this case if 'playing' would precede 'timeupdate' or 'seeked'. anandc 2013/07/25 22:48:00 Based on all your comments, adding an explicit wai Show quoted text On 2013/07/24 23:16:43, wolenetz wrote: > You'll need a 'timeupdate' expectation between 'seeking' and 'seeked', and it > would be good to confirm on receipt of this specific 'timeupdate' that seeking > is true and currentTime is the expected seek target (0.0). > Note also that some implementations may already have expired already played data > in buffers, and may also issue 'waiting' between 'seeking' and 'timeupdate' and > also 'playing', though I'm not exactly clear in this case if 'playing' would > precede 'timeupdate' or 'seeked'. Based on all your comments, adding an explicit wait with setTimeout now, to let media play before seeking back.
	47 test.expectEvent(mediaElement, "playing", "Playing triggered") ;
	wolenetz 2013/07/24 23:16:43 I don't think 'playing' is expected here, unless t I don't think 'playing' is expected here, unless there was some intervening 'waiting' for data to be (re-)appended for the media time 0. Even then, 'playing' might be required to dispatch prior to the timeupdate or seeked events (see previous comment). anandc 2013/07/26 18:49:22 Correct, rearranged the flow now. Show quoted text On 2013/07/24 23:16:43, wolenetz wrote: > I don't think 'playing' is expected here, unless there was some intervening > 'waiting' for data to be (re-)appended for the media time 0. Even then, > 'playing' might be required to dispatch prior to the timeupdate or seeked events > (see previous comment). Correct, rearranged the flow now.
	48 test.expectEvent(mediaElement, "timeupdate", "timeupdate fired .");
	wolenetz 2013/07/24 23:16:43 Note for future: you'll actually get lots and lots Note for future: you'll actually get lots and lots of these (every 250ms during normal playback progress). Expecting just one here should be OK though. anandc 2013/07/26 18:49:22 ok Show quoted text On 2013/07/24 23:16:43, wolenetz wrote: > Note for future: you'll actually get lots and lots of these (every 250ms during > normal playback progress). Expecting just one here should be OK though. ok
	49 mediaElement.currentTime = 0.0;

	50 }

	51 });

	52

	53 test.waitForExpectedEvents(function()
	wolenetz 2013/07/24 23:16:43 It's highly likely that the previous currentTime > It's highly likely that the previous currentTime > 0.5 check will fail. Perhaps you want to setTimeout() to give playback some time after "playing" event received? Otherwise, it's likely new expectations for events won't be added, and the seek back to 0 will not have been started at this point. anandc 2013/07/26 18:49:22 Done. Show quoted text On 2013/07/24 23:16:43, wolenetz wrote: > It's highly likely that the previous currentTime > 0.5 check will fail. Perhaps > you want to setTimeout() to give playback some time after "playing" event > received? Otherwise, it's likely new expectations for events won't be added, and > the seek back to 0 will not have been started at this point. Done.
	54 {

	55 assert_greater_than(mediaElement.readyState,

	56 mediaElement.HAVE_FUTURE_DATA, "Greater than HAVE_FUTURE_DATA" );
	wolenetz 2013/07/24 23:16:43 I'm not sure all implementations can guarantee the I'm not sure all implementations can guarantee they estimate they can play through to completion at this point. This assertion may introduce flakiness. anandc 2013/07/26 18:49:22 Removed. Show quoted text On 2013/07/24 23:16:43, wolenetz wrote: > I'm not sure all implementations can guarantee they estimate they can play > through to completion at this point. This assertion may introduce flakiness. Removed.
	57 test.done();

	58 });

	59

	60 }, "Test playing then seeking back.");

	61 </script>

	62 </body>

	63 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/http/tests/media/media-source/mediasource-play-then-seek-back-expected.txt » ('j') | no next file with comments »