Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20114003: Update include paths in miscellaneous content/ directories for base/process changes. (Closed)

Created:
7 years, 5 months ago by Robert Sesek
Modified:
7 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tzik+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jochen+watch_chromium.org
Visibility:
Public.

Description

Update include paths in miscellaneous content/ directories for base/process changes. BUG=242290 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213619

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Fixy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M chrome/browser/memory_details_android.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/app/content_main_runner.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/child/child_process.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/fileapi/file_system_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/fileapi/file_system_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/np_channel_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/plugin/plugin_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_channel.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_thread.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/webkit_test_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/zygote/zygote_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Robert Sesek
Last one, I promise :)
7 years, 5 months ago (2013-07-24 20:46:11 UTC) #1
Avi (use Gerrit)
lgtm stamp
7 years, 5 months ago (2013-07-24 20:51:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/20114003/2001
7 years, 5 months ago (2013-07-24 20:59:38 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-24 21:49:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/20114003/17001
7 years, 5 months ago (2013-07-24 22:03:15 UTC) #5
Robert Sesek
Committed patchset #3 manually as r213619 (presubmit successful).
7 years, 5 months ago (2013-07-25 13:02:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/20114003/20001
7 years, 5 months ago (2013-07-25 14:27:25 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-25 14:27:32 UTC) #8
Message was sent while issue was closed. 
Failed to apply patch for chrome/browser/memory_details_android.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/memory_details_android.cc
  Hunk #1 FAILED at 10.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/memory_details_android.cc.rej

Patch:       chrome/browser/memory_details_android.cc
Index: chrome/browser/memory_details_android.cc
diff --git a/chrome/browser/memory_details_android.cc
b/chrome/browser/memory_details_android.cc
index
9be87ae57d708636347507bd848b4d0a52d3588d..fab8422f04985e4d0528f8a82ed4f77776241f62
100644
--- a/chrome/browser/memory_details_android.cc
+++ b/chrome/browser/memory_details_android.cc
@@ -10,6 +10,7 @@
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/process/process_iterator.h"
 #include "chrome/common/chrome_constants.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/process_type.h"

Powered by Google App Engine
This is Rietveld 408576698