Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2011393002: Disconnect from WebAPK service when the WebAPK is stopped (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
gone
CC:
chromium-reviews, Xi Han, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disconnect from WebAPK service when the WebAPK is stopped BUG=609122 Committed: https://crrev.com/689bf7d77fc10ca7155bb59c91f6c681e7afb2a2 Cr-Commit-Position: refs/heads/master@{#396625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pkotwicz
dfalcantara@ PTAL The connection to the WebAPK service is established in WebApkNotificationClient#notifyNotification()
4 years, 6 months ago (2016-05-27 19:37:01 UTC) #2
gone
lgtm
4 years, 6 months ago (2016-05-27 21:34:08 UTC) #3
gone
You don't need native, right?
4 years, 6 months ago (2016-05-27 21:34:18 UTC) #4
pkotwicz
Nope, we do not need native
4 years, 6 months ago (2016-05-28 01:29:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011393002/1
4 years, 6 months ago (2016-05-28 01:30:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-28 02:04:34 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 02:05:54 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/689bf7d77fc10ca7155bb59c91f6c681e7afb2a2
Cr-Commit-Position: refs/heads/master@{#396625}

Powered by Google App Engine
This is Rietveld 408576698