H264POC: Re-compute PicOrderCnt for duplicate frame_nums.

H264POC: Re-compute PicOrderCnt for duplicate frame_nums.

Some videos violate the H.264 spec by having sequential frames with the
same |frame_num|. This CL changes H264POC to match the behavior of
H264Decoder in that case.

BUG=615289
Committed: https://crrev.com/f9178e0325ced73b38cc89e000fcc0703301f092
Cr-Commit-Position: refs/heads/master@{#397633}

[sandersd (OOO until July 31), 2016-05-27 19:19:10]

sandersd@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-05-27 19:30:02]

Either add a test or comment explaining why you reverted this behavior with
links to the bugs so that future travelers don't try to readd it.

[sandersd (OOO until July 31), 2016-06-02 18:23:04]

On 2016/05/27 19:30:02, DaleCurtis wrote:
> Either add a test or comment explaining why you reverted this behavior with
> links to the bugs so that future travelers don't try to readd it.

Test added, PTAL.

[DaleCurtis, 2016-06-02 18:53:02]

lgtm % comment changes.

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc_un...
File media/video/h264_poc_unittest.cc (right):

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc_un...
media/video/h264_poc_unittest.cc:195: // Despite being invalid, videos with
diplicate non-keyframe |frame_num| values
duplicate.

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc_un...
media/video/h264_poc_unittest.cc:196: // are common.
Add link to bugs?

[DaleCurtis, 2016-06-02 18:54:05]

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc.cc
File media/video/h264_poc.cc (left):

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc.cc...
media/video/h264_poc.cc:66: if (!slice_hdr.idr_pic_flag && slice_hdr.frame_num
== prev_frame_num_) {
Up to you but a note somewhere along in this function might be useful too.

[sandersd (OOO until July 31), 2016-06-02 18:58:55]

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc.cc
File media/video/h264_poc.cc (left):

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc.cc...
media/video/h264_poc.cc:66: if (!slice_hdr.idr_pic_flag && slice_hdr.frame_num
== prev_frame_num_) {
On 2016/06/02 18:54:05, DaleCurtis wrote:
> Up to you but a note somewhere along in this function might be useful too.

Done.

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc_un...
File media/video/h264_poc_unittest.cc (right):

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc_un...
media/video/h264_poc_unittest.cc:195: // Despite being invalid, videos with
diplicate non-keyframe |frame_num| values
On 2016/06/02 18:53:02, DaleCurtis wrote:
> duplicate.

Done.

https://codereview.chromium.org/2011353003/diff/20001/media/video/h264_poc_un...
media/video/h264_poc_unittest.cc:196: // are common.
On 2016/06/02 18:53:02, DaleCurtis wrote:
> Add link to bugs?

Done.

[sandersd (OOO until July 31), 2016-06-02 18:59:39]

The CQ bit was checked by sandersd@chromium.org

[sandersd (OOO until July 31), 2016-06-02 18:59:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2011353003/#ps40001
(title: "Comments")

[commit-bot: I haz the power, 2016-06-02 19:00:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011353003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011353003/40001

[commit-bot: I haz the power, 2016-06-03 02:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 02:14:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[DaleCurtis, 2016-06-03 02:25:05]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-06-03 02:26:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011353003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011353003/40001

[commit-bot: I haz the power, 2016-06-03 04:43:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 04:45:03]

Description was changed from

==========
H264POC: Re-compute PicOrderCnt for duplicate frame_nums.

Some videos violate the H.264 spec by having sequential frames with the
same |frame_num|. This CL changes H264POC to match the behavior of
H264Decoder in that case.

BUG=615289
==========

to

==========
H264POC: Re-compute PicOrderCnt for duplicate frame_nums.

Some videos violate the H.264 spec by having sequential frames with the
same |frame_num|. This CL changes H264POC to match the behavior of
H264Decoder in that case.

BUG=615289

Committed: https://crrev.com/f9178e0325ced73b38cc89e000fcc0703301f092
Cr-Commit-Position: refs/heads/master@{#397633}
==========

[commit-bot: I haz the power, 2016-06-03 04:45:04]

Patchset 3 (id:??) landed as
https://crrev.com/f9178e0325ced73b38cc89e000fcc0703301f092
Cr-Commit-Position: refs/heads/master@{#397633}