Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2011323002: Fix handling of identifier sequences starting with a function parameter. (Closed)

Created:
4 years, 6 months ago by Paul Berry
Modified:
4 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix handling of identifier sequences starting with a function parameter. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/84c5cd016e0770267b8c4ade42cbca3011a1dbc8

Patch Set 1 #

Patch Set 2 : Fix an errant test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 4 chunks +14 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 2 chunks +125 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 6 months ago (2016-05-27 11:33:36 UTC) #2
scheglov
LGTM
4 years, 6 months ago (2016-05-27 15:28:14 UTC) #3
Paul Berry
4 years, 6 months ago (2016-05-27 15:45:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
84c5cd016e0770267b8c4ade42cbca3011a1dbc8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698