[Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a JSFrame.

[Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a JSFrame.

GenerateSmiToDouble on ia32 assumes that it is called from a JSFrame and can restore
the context from the StandardFrameConstants::kContextObject. In the case of the
interpreter it is called from a interpreter handler stub frame which doesn't
push the context onto it's frame. Instead, push and pop esi to explicitly restore it
correctly.

BUG=chromium:612386
Committed: https://crrev.com/471893ccec1b280453bf49b8bba9f6331ee2b41b
Cr-Commit-Position: refs/heads/master@{#36649}

[rmcilroy, 2016-05-27 12:51:20]

rmcilroy@chromium.org changed reviewers:
+ mvstanton@chromium.org

[rmcilroy, 2016-05-27 12:51:21]

Michael, could you take a look please. Thanks.

[rmcilroy, 2016-06-01 08:55:47]

Ping? Michael could you take a quick look? I'd like to land this to fix a
crasher in Dev/Canary.

[rmcilroy, 2016-06-01 12:44:07]

Description was changed from

==========
[Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a
JSFrame.

GenerateSmiToDouble on ia32 assumes that it is called from a JSFrame and can
restore
the context from the StandardFrameConstants::kContextObject. In the case of the
interpreter it is called from a interpreter handler stub frame which doesn't
push the context onto it's frame. Instead, push and pop esi to explicitly
restore it
correctly.

BUG=612386
==========

to

==========
[Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a
JSFrame.

GenerateSmiToDouble on ia32 assumes that it is called from a JSFrame and can
restore
the context from the StandardFrameConstants::kContextObject. In the case of the
interpreter it is called from a interpreter handler stub frame which doesn't
push the context onto it's frame. Instead, push and pop esi to explicitly
restore it
correctly.

BUG=chromium:612386
==========

[mvstanton, 2016-06-01 13:50:23]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-06-01 13:50:24]

lgtm

[mvstanton, 2016-06-01 13:50:28]

The CQ bit was unchecked by mvstanton@chromium.org

[rmcilroy, 2016-06-01 14:22:04]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-06-01 14:22:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011313003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011313003/1

[commit-bot: I haz the power, 2016-06-01 14:47:08]

Description was changed from

==========
[Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a
JSFrame.

GenerateSmiToDouble on ia32 assumes that it is called from a JSFrame and can
restore
the context from the StandardFrameConstants::kContextObject. In the case of the
interpreter it is called from a interpreter handler stub frame which doesn't
push the context onto it's frame. Instead, push and pop esi to explicitly
restore it
correctly.

BUG=chromium:612386
==========

to

==========
[Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a
JSFrame.

GenerateSmiToDouble on ia32 assumes that it is called from a JSFrame and can
restore
the context from the StandardFrameConstants::kContextObject. In the case of the
interpreter it is called from a interpreter handler stub frame which doesn't
push the context onto it's frame. Instead, push and pop esi to explicitly
restore it
correctly.

BUG=chromium:612386
==========

[commit-bot: I haz the power, 2016-06-01 14:47:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-01 14:49:07]

Description was changed from

==========
[Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a
JSFrame.

GenerateSmiToDouble on ia32 assumes that it is called from a JSFrame and can
restore
the context from the StandardFrameConstants::kContextObject. In the case of the
interpreter it is called from a interpreter handler stub frame which doesn't
push the context onto it's frame. Instead, push and pop esi to explicitly
restore it
correctly.

BUG=chromium:612386
==========

to

==========
[Interpreter] Fix GenerateSmiToDouble to avoid assuming it is called from a
JSFrame.

GenerateSmiToDouble on ia32 assumes that it is called from a JSFrame and can
restore
the context from the StandardFrameConstants::kContextObject. In the case of the
interpreter it is called from a interpreter handler stub frame which doesn't
push the context onto it's frame. Instead, push and pop esi to explicitly
restore it
correctly.

BUG=chromium:612386

Committed: https://crrev.com/471893ccec1b280453bf49b8bba9f6331ee2b41b
Cr-Commit-Position: refs/heads/master@{#36649}
==========

[commit-bot: I haz the power, 2016-06-01 14:49:08]

Patchset 1 (id:??) landed as
https://crrev.com/471893ccec1b280453bf49b8bba9f6331ee2b41b
Cr-Commit-Position: refs/heads/master@{#36649}