Certificate Transparency: Adding CNNIC's CT log server.

Certificate Transparency: Adding CNNIC's CT log server.

Said log has been pending inclusion since February 26th, 2016, and
has complied with the requirements for inclusion.

BUG=583208
Committed: https://crrev.com/3a79a2a6429d0adf9d03cd37e3da2850869d4fa6
Cr-Commit-Position: refs/heads/master@{#396817}

[Eran Messeri, 2016-05-27 11:00:49]

Description was changed from

==========
Certificate Transparency: Adding CNNIC's CT log server.

Said log has been pending inclusion since February 26th, 2016, and
has complied with the requirements for inclusion.

BUG=583208
==========

to

==========
Certificate Transparency: Adding CNNIC's CT log server.

Said log has been pending inclusion since February 26th, 2016, and
has complied with the requirements for inclusion.

BUG=583208
==========

[Eran Messeri, 2016-05-27 11:00:49]

eranm@chromium.org changed reviewers:
+ eroman@chromium.org

[Eran Messeri, 2016-05-27 11:02:01]

Eric, a small change to the CT log list for you to review, as you've just
reviewed another change to it.

[eroman, 2016-05-27 21:12:17]

lgtm

[eroman, 2016-05-27 21:15:01]

Thinking out loud:

It may be useful to have some documentation for each log pointing to the process
of how it was added -- in this case, just link to the crbug.com/ issue for
adding CNNIC.

Or if there is a document or authoritative registry maintained somewhere else
that justifies the log list.

[Ryan Sleevi, 2016-05-28 08:21:46]

> It may be useful to have some documentation for each log pointing to the
process
> of how it was added -- in this case, just link to the crbug.com/ issue for
> adding CNNIC.

Do you mean documentation internally? That's what blame is for.

I'm not sure I get what you're getting at.

[eroman, 2016-05-30 21:52:59]

There is a policy for including CT log servers no?

Why not then include details for inclusion beside the entry, rather than
spelunking through git blame to maybe find it.

As a reader I would appreciate seeing the reason for things inline, rather than
an undocumented blob of data.

[Eran Messeri, 2016-05-31 11:21:50]

On 2016/05/30 21:52:59, eroman wrote:
> There is a policy for including CT log servers no?
> 
> Why not then include details for inclusion beside the entry, rather than
> spelunking through git blame to maybe find it.
> 
> As a reader I would appreciate seeing the reason for things inline, rather
than
> an undocumented blob of data.

That's a good point - currently we do not export externally-visible data about
logs' compliance status.
We're working on a new dashboard with data we could export. In the meanwhile,
I'll send the link internally.

[Eran Messeri, 2016-05-31 11:54:25]

The CQ bit was checked by eranm@chromium.org

[commit-bot: I haz the power, 2016-05-31 11:54:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011313002/1

[commit-bot: I haz the power, 2016-05-31 12:38:07]

Description was changed from

==========
Certificate Transparency: Adding CNNIC's CT log server.

Said log has been pending inclusion since February 26th, 2016, and
has complied with the requirements for inclusion.

BUG=583208
==========

to

==========
Certificate Transparency: Adding CNNIC's CT log server.

Said log has been pending inclusion since February 26th, 2016, and
has complied with the requirements for inclusion.

BUG=583208
==========

[commit-bot: I haz the power, 2016-05-31 12:38:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-31 12:39:31]

Description was changed from

==========
Certificate Transparency: Adding CNNIC's CT log server.

Said log has been pending inclusion since February 26th, 2016, and
has complied with the requirements for inclusion.

BUG=583208
==========

to

==========
Certificate Transparency: Adding CNNIC's CT log server.

Said log has been pending inclusion since February 26th, 2016, and
has complied with the requirements for inclusion.

BUG=583208

Committed: https://crrev.com/3a79a2a6429d0adf9d03cd37e3da2850869d4fa6
Cr-Commit-Position: refs/heads/master@{#396817}
==========

[commit-bot: I haz the power, 2016-05-31 12:39:32]

Patchset 1 (id:??) landed as
https://crrev.com/3a79a2a6429d0adf9d03cd37e3da2850869d4fa6
Cr-Commit-Position: refs/heads/master@{#396817}

[eroman, 2016-05-31 19:52:28]

Thanks for the background Eran.

Having some extra comments here in the future would be appreciated.