DevTools: Create target per each worker behind experiment

DevTools: Create target per each worker behind experiment

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169651

[vsevik, 2014-03-19 15:54:38]

https://chromiumcodereview.appspot.com/201123007/diff/1/Source/devtools/front...
File Source/devtools/front_end/WorkerTargetsProvider.js (right):

https://chromiumcodereview.appspot.com/201123007/diff/1/Source/devtools/front...
Source/devtools/front_end/WorkerTargetsProvider.js:12:
WebInspector.WorkerTargetsProvider = function(mainTarget, targetManager)
WorkerTargetManager

https://chromiumcodereview.appspot.com/201123007/diff/1/Source/devtools/front...
Source/devtools/front_end/WorkerTargetsProvider.js:27: new
WebInspector.WorkerConnectionInSameFrontend(this._mainTarget, data.workerId,
onConnectionReady.bind(this));
why not var connection = ?

https://chromiumcodereview.appspot.com/201123007/diff/1/Source/devtools/front...
Source/devtools/front_end/WorkerTargetsProvider.js:33: function
onConnectionReady(connection)
why do you need to pass connection as a callback parameter?

https://chromiumcodereview.appspot.com/201123007/diff/1/Source/devtools/front...
Source/devtools/front_end/WorkerTargetsProvider.js:56:
WebInspector.WorkerConnectionInSameFrontend = function(target, workerId,
onConnectionReady)
Let's name this one WorkerConnection and the other one ExternalWorkerConnection

[sergeyv, 2014-03-19 16:28:58]

https://chromiumcodereview.appspot.com/201123007/diff/1/Source/devtools/front...
File Source/devtools/front_end/WorkerTargetsProvider.js (right):

https://chromiumcodereview.appspot.com/201123007/diff/1/Source/devtools/front...
Source/devtools/front_end/WorkerTargetsProvider.js:12:
WebInspector.WorkerTargetsProvider = function(mainTarget, targetManager)
On 2014/03/19 15:54:39, vsevik wrote:
> WorkerTargetManager

Done.

https://chromiumcodereview.appspot.com/201123007/diff/1/Source/devtools/front...
Source/devtools/front_end/WorkerTargetsProvider.js:56:
WebInspector.WorkerConnectionInSameFrontend = function(target, workerId,
onConnectionReady)
On 2014/03/19 15:54:39, vsevik wrote:
> Let's name this one WorkerConnection and the other one
ExternalWorkerConnection

Done.

[vsevik, 2014-03-19 16:33:39]

lgtm

https://chromiumcodereview.appspot.com/201123007/diff/20001/Source/devtools/f...
File Source/devtools/front_end/WorkerTargetManager.js (right):

https://chromiumcodereview.appspot.com/201123007/diff/20001/Source/devtools/f...
Source/devtools/front_end/WorkerTargetManager.js:3: * Use of this source code is
governed by a BSD-style license that can be
I would prefer 3 lines license.

https://chromiumcodereview.appspot.com/201123007/diff/20001/Source/devtools/f...
File Source/devtools/front_end/inspector.js (right):

https://chromiumcodereview.appspot.com/201123007/diff/20001/Source/devtools/f...
Source/devtools/front_end/inspector.js:354: if
(WebInspector.experimentsSettings.workersInMainWindow.isEnabled())
Let's move this to the beginning of the method.

[sergeyv, 2014-03-19 16:43:50]

https://chromiumcodereview.appspot.com/201123007/diff/20001/Source/devtools/f...
File Source/devtools/front_end/WorkerTargetManager.js (right):

https://chromiumcodereview.appspot.com/201123007/diff/20001/Source/devtools/f...
Source/devtools/front_end/WorkerTargetManager.js:3: * Use of this source code is
governed by a BSD-style license that can be
On 2014/03/19 16:33:39, vsevik wrote:
> I would prefer 3 lines license.

Done.

https://chromiumcodereview.appspot.com/201123007/diff/20001/Source/devtools/f...
File Source/devtools/front_end/inspector.js (right):

https://chromiumcodereview.appspot.com/201123007/diff/20001/Source/devtools/f...
Source/devtools/front_end/inspector.js:354: if
(WebInspector.experimentsSettings.workersInMainWindow.isEnabled())
On 2014/03/19 16:33:39, vsevik wrote:
> Let's move this to the beginning of the method.

Done.

[sergeyv, 2014-03-19 16:43:54]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-03-19 16:43:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyv@chromium.org/201123007/40001

[commit-bot: I haz the power, 2014-03-19 16:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 16:44:05]

Failed to apply patch for Source/devtools/front_end/inspector.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/devtools/front_end/inspector.js
  |diff --git a/Source/devtools/front_end/inspector.js
b/Source/devtools/front_end/inspector.js
  |index
590a0fad33bc3144f4d5fb6c8ff772328d37789b..f09dff4206508c744ed366681ff54f40701e8a7a
100644
  |--- a/Source/devtools/front_end/inspector.js
  |+++ b/Source/devtools/front_end/inspector.js
  --------------------------
  No file to patch.  Skipping patch.
  2 out of 2 hunks ignored

Patch:       Source/devtools/front_end/inspector.js
Index: Source/devtools/front_end/inspector.js
diff --git a/Source/devtools/front_end/inspector.js
b/Source/devtools/front_end/inspector.js
index
590a0fad33bc3144f4d5fb6c8ff772328d37789b..f09dff4206508c744ed366681ff54f40701e8a7a
100644
--- a/Source/devtools/front_end/inspector.js
+++ b/Source/devtools/front_end/inspector.js
@@ -188,7 +188,7 @@ WebInspector.Main.prototype = {
 
         var workerId = WebInspector.queryParam("dedicatedWorkerId");
         if (workerId) {
-            new WebInspector.WorkerConnection(workerId, onConnectionReady);
+            new WebInspector.ExternalWorkerConnection(workerId,
onConnectionReady);
             return;
         }
 
@@ -256,6 +256,9 @@ WebInspector.Main.prototype = {
         WebInspector.shortcutsScreen.section(WebInspector.UIString("Elements
Panel"));
         WebInspector.ShortcutsScreen.registerShortcuts();
 
+        if (WebInspector.experimentsSettings.workersInMainWindow.isEnabled())
+            new WebInspector.WorkerTargetManager(mainTarget,
WebInspector.targetManager);
+
        
WebInspector.console.addEventListener(WebInspector.ConsoleModel.Events.ConsoleCleared,
this._resetErrorAndWarningCounts, this);
        
WebInspector.console.addEventListener(WebInspector.ConsoleModel.Events.MessageAdded,
this._updateErrorAndWarningCounts, this);
        
WebInspector.console.addEventListener(WebInspector.ConsoleModel.Events.RepeatCountUpdated,
this._updateErrorAndWarningCounts, this);

[sergeyv, 2014-03-20 09:34:15]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-03-20 09:34:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyv@chromium.org/201123007/60001

[commit-bot: I haz the power, 2014-03-20 10:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 10:38:53]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[sergeyv, 2014-03-20 11:51:52]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2014-03-20 11:52:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyv@chromium.org/201123007/60001

[commit-bot: I haz the power, 2014-03-20 12:57:11]

Change committed as 169651