Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 201123004: Ignore MediaController in the closed captions button logic (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Ignore MediaController in the closed captions button logic Involving the media controller plainly does not make sense. There was no test coverage for the CC button with a media controller present, and adding a negative test for it does not seem useful. Note that what remains is still not great since it doesn't allow you to pick between multiple tracks, but that will be fixed at a later time. BUG=341813 TEST=LayoutTests/media/audio-controls-captions.html LayoutTests/media/video-controls-captions.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -32 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/MediaController.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/html/MediaController.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M Source/core/html/MediaControllerInterface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-17 01:49:42 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-18 00:10:23 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-18 02:05:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/201123004/1
6 years, 9 months ago (2014-03-18 03:19:09 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 03:30:50 UTC) #5
Message was sent while issue was closed.
Change committed as 169405

Powered by Google App Engine
This is Rietveld 408576698