Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2011223003: Unship ES2015 for-in initializer restrictions (Closed)

Created:
4 years, 6 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
Reviewers:
rossberg, adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unship ES2015 for-in initializer restrictions We now have data that 0.011% of websites use the pattern for (var i = 0 in j) { ... } This pattern was banned by ES2015, with the idea to revisit if it presents a web compatibility problem. Informally, after the May 2016 TC39 meeting, the new data was discussed, and there was interest in reversing the decision. Although the specification is not yet updated, it seems likely to come soon. This patch turns off the flag which bans that construct, reenabling it. The change should prevent websites from breaking. BUG=v8:4942 Committed: https://crrev.com/7245dabdb1c4f7dc5fec06cc087e9c4180df474a Cr-Commit-Position: refs/heads/master@{#36562}

Patch Set 1 #

Patch Set 2 : Fix webkit test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/webkit/fast/js/parser-syntax-check-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011223003/1
4 years, 6 months ago (2016-05-27 09:41:01 UTC) #2
Dan Ehrenberg
4 years, 6 months ago (2016-05-27 09:41:23 UTC) #4
Dan Ehrenberg
On 2016/05/27 at 09:41:23, Dan Ehrenberg wrote: > If this goes in, we should backport ...
4 years, 6 months ago (2016-05-27 09:54:56 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/2316) v8_linux_nodcheck_rel_ng_triggered on ...
4 years, 6 months ago (2016-05-27 09:57:31 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011223003/20001
4 years, 6 months ago (2016-05-27 13:21:19 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 14:21:02 UTC) #11
adamk
lgtm
4 years, 6 months ago (2016-05-27 18:56:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011223003/20001
4 years, 6 months ago (2016-05-27 19:10:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 19:12:10 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 19:14:55 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7245dabdb1c4f7dc5fec06cc087e9c4180df474a
Cr-Commit-Position: refs/heads/master@{#36562}

Powered by Google App Engine
This is Rietveld 408576698