Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2011183005: S390: Move of the type feedback vector to the closure. (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Move of the type feedback vector to the closure. Port 91c88644dcf396285f88977080ea85f4614bbc02 Original commit message: We get less "pollution" of type feedback if we have one vector per native context, rather than one for the whole system. This CL moves the vector appropriately. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/66ac70932f48d24b409f21a0942be74bed923504 Cr-Commit-Position: refs/heads/master@{#36564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/s390/macro-assembler-s390.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
john.yan
PTAL
4 years, 6 months ago (2016-05-27 21:08:11 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011183005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011183005/1
4 years, 6 months ago (2016-05-27 21:08:23 UTC) #3
commit-bot: I haz the power
Dry run: The author jyan@ca.ibm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com ...
4 years, 6 months ago (2016-05-27 21:08:25 UTC) #5
john.yan
lgtm
4 years, 6 months ago (2016-05-27 21:08:38 UTC) #6
JoranSiu
On 2016/05/27 21:08:38, john.yan wrote: > lgtm lgtm
4 years, 6 months ago (2016-05-27 21:10:54 UTC) #7
john.yan
lgtm
4 years, 6 months ago (2016-05-27 21:13:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011183005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011183005/1
4 years, 6 months ago (2016-05-27 21:13:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 21:38:18 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:40:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66ac70932f48d24b409f21a0942be74bed923504
Cr-Commit-Position: refs/heads/master@{#36564}

Powered by Google App Engine
This is Rietveld 408576698