Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 2011183002: Fix flaky BidirectionalStreamTest (Closed)

Created:
4 years, 6 months ago by xunjieli
Modified:
4 years, 6 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky BidirectionalStreamTest This CL attempts to fix the flakiness observed on DrMemory bots by running the current message loop until idle after resuming the sequence socket data. R=mef@chromium.org BUG=604611 Committed: https://crrev.com/62f6782adc7b8f3a2b7fa8445975e828362aadbd Cr-Commit-Position: refs/heads/master@{#397188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M net/http/bidirectional_stream_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/net_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xunjieli
4 years, 6 months ago (2016-05-26 21:23:29 UTC) #1
mef
lgtm
4 years, 6 months ago (2016-06-01 17:14:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011183002/1
4 years, 6 months ago (2016-06-01 17:16:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 18:29:44 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 19:11:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62f6782adc7b8f3a2b7fa8445975e828362aadbd
Cr-Commit-Position: refs/heads/master@{#397188}

Powered by Google App Engine
This is Rietveld 408576698