Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2011123002: Add a null check in ConnectivityManagerDelegate.getNetworkState (Closed)

Created:
4 years, 7 months ago by mef
Modified:
4 years, 7 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2739
Target Ref:
refs/pending/branch-heads/2739
Project:
chromium
Visibility:
Public.

Description

Add a null check in ConnectivityManagerDelegate.getNetworkState ConnectivityManager.getNetworkInfo can return null if the Network is invalid. This CL adds a null check so we don't crash with a NullPointerException when invoking networkInfo.getType() BUG=613599 Review-Url: https://codereview.chromium.org/2003503003 Cr-Commit-Position: refs/heads/master@{#395375} (cherry picked from commit ff2ec75896222f8a2ddc6b9e1551276929a0b671) R=xunjieli@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d95785fc583925674b97a54860e5fa46a168be6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 1 chunk +1 line, -1 line 0 comments Download
M net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mef
Hi Helen, PTAL. This is merging your fix into 2739. thanks, -m
4 years, 7 months ago (2016-05-26 18:48:34 UTC) #2
xunjieli
lgtm. thanks for the merge!
4 years, 7 months ago (2016-05-26 18:51:24 UTC) #3
mef
4 years, 7 months ago (2016-05-26 19:00:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d95785fc583925674b97a54860e5fa46a168be6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698