Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: gyp/dng_sdk.gyp

Issue 2011073002: Work around missing __mulodi4() on ARMv7 + Clang builds. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add bug note Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/dng_sdk.gyp
diff --git a/gyp/dng_sdk.gyp b/gyp/dng_sdk.gyp
index 3d426241e6fc330d57d7655da01839a90d4fb0d5..be0c0f97db1673566d2eb3ef85a88863d093debd 100644
--- a/gyp/dng_sdk.gyp
+++ b/gyp/dng_sdk.gyp
@@ -143,6 +143,14 @@
['skia_os != "linux"', {
'sources': ['<@(headers)'],
}],
+ ['skia_arch_type == "arm" and skia_clang_build', {
+ # DNG SDK uses __builtin_smulll_overflow() to detect 64x64 bit multiply overflow.
+ # On ARMv7, Clang implements this with __mulodi4() in libclang_rt.
+ # I can't quite figure out how to link that here, so instead here's a shim for
+ # __builtin_smulll_overflow() that multiplies normally assuming no overflow.
+ # Tracked in b/29412086.
+ 'defines': [ '__builtin_smulll_overflow(x,y,p)=(*(p)=(x)*(y), false)' ],
+ }],
],
'dependencies': [
'libjpeg-turbo-selector.gyp:libjpeg-turbo-selector',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698