Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2011053003: Make PlatformViewport and NativeViewportImpl use Shell* instead of ApplicationImpl*. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make PlatformViewport and NativeViewportImpl use Shell* instead of ApplicationImpl*. Even Shell* probably isn't entirely ideal (since then you have to worry about lifetime), but it'll do for now. This will be needed to move the native viewport service away from using ApplicationDelegate, etc. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/32b469b2d747a647c3def601550f7807607bf387

Patch Set 1 #

Patch Set 2 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -36 lines) Patch
M services/native_viewport/app_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/native_viewport_impl.h View 3 chunks +6 lines, -4 lines 0 comments Download
M services/native_viewport/native_viewport_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M services/native_viewport/ozone/platform_viewport_ozone.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M services/native_viewport/platform_viewport.h View 2 chunks +4 lines, -2 lines 0 comments Download
M services/native_viewport/platform_viewport_android.h View 3 chunks +3 lines, -4 lines 0 comments Download
M services/native_viewport/platform_viewport_android.cc View 4 chunks +7 lines, -10 lines 0 comments Download
M services/native_viewport/platform_viewport_stub.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M services/native_viewport/platform_viewport_x11.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M shell/android/native_viewport_application_loader.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-26 17:56:50 UTC) #1
vardhan
android tests failing
4 years, 7 months ago (2016-05-26 18:04:58 UTC) #2
viettrungluu
On 2016/05/26 18:04:58, vardhan wrote: > android tests failing D'oh. Fixed, I think. PTAL.
4 years, 7 months ago (2016-05-26 18:25:21 UTC) #3
vardhan
lgtm
4 years, 7 months ago (2016-05-26 21:55:17 UTC) #4
viettrungluu
4 years, 7 months ago (2016-05-26 22:11:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
32b469b2d747a647c3def601550f7807607bf387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698