Use an interface to get to the C++ object pointer instead of casting directly...

Use an interface to get to the C++ object pointer instead of casting directly.
The object was being marshalled so, we were casting an ole32 proxy object to our implementation.  To avoid marshalling altogether I'm also using the FTM. So, yeah, we're going belt and suspenders.

TEST=See bug.
BUG=43988
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47160

[ananta, 2010-05-12 20:47:15]

ok

http://codereview.chromium.org/2011016/diff/5001/6002
File chrome_frame/bind_context_info.h (right):

http://codereview.chromium.org/2011016/diff/5001/6002#newcode27
chrome_frame/bind_context_info.h:27: ~BindContextInfo() {
Please move the destructor to the source file

http://codereview.chromium.org/2011016/diff/5001/6002#newcode68
chrome_frame/bind_context_info.h:68: url_ = url;
if url is NULL we would crash here.

http://codereview.chromium.org/2011016/diff/5001/6002#newcode77
chrome_frame/bind_context_info.h:77: *me = static_cast<BindContextInfo*>(this);
DCHECK(me)?

[tommi (sloooow) - chröme, 2010-05-12 21:08:58]

http://codereview.chromium.org/2011016/diff/5001/6002
File chrome_frame/bind_context_info.h (right):

http://codereview.chromium.org/2011016/diff/5001/6002#newcode27
chrome_frame/bind_context_info.h:27: ~BindContextInfo() {
On 2010/05/12 20:47:16, ananta wrote:
> Please move the destructor to the source file

Done.

http://codereview.chromium.org/2011016/diff/5001/6002#newcode68
chrome_frame/bind_context_info.h:68: url_ = url;
On 2010/05/12 20:47:16, ananta wrote:
> if url is NULL we would crash here.

good point.  fixed.
(that was true before, right?)

http://codereview.chromium.org/2011016/diff/5001/6002#newcode77
chrome_frame/bind_context_info.h:77: *me = static_cast<BindContextInfo*>(this);
On 2010/05/12 20:47:16, ananta wrote:
> DCHECK(me)?

Done.

[amit, 2010-05-12 21:16:49]

Nice catch! lgtm

http://codereview.chromium.org/2011016/diff/5001/6001
File chrome_frame/bind_context_info.cc (right):

http://codereview.chromium.org/2011016/diff/5001/6001#newcode46
chrome_frame/bind_context_info.cc:46: hr =
CoCreateFreeThreadedMarshaler(bind_context_info->GetUnknown(),
ideally, this (and the RegisterObjectParam) should be done in
BindContextInfo::Setup or something...

[tommi (sloooow) - chröme, 2010-05-13 17:47:50]

http://codereview.chromium.org/2011016/diff/5001/6001
File chrome_frame/bind_context_info.cc (right):

http://codereview.chromium.org/2011016/diff/5001/6001#newcode46
chrome_frame/bind_context_info.cc:46: hr =
CoCreateFreeThreadedMarshaler(bind_context_info->GetUnknown(),
On 2010/05/12 21:16:49, amit wrote:
> ideally, this (and the RegisterObjectParam) should be done in
> BindContextInfo::Setup or something...

Done.