Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2010983002: Test that failed sync scripts do not block later ones. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test that failed sync scripts do not block later ones. If an async=false script fails to load, it must not block later sync scripts from executing; add missing test coverage. R= BUG=614855, 581425 Committed: https://crrev.com/0f654575292abfd9b5b894ec5f3fffd457940fee Cr-Commit-Position: refs/heads/master@{#396253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/HTMLScriptElement/resources/success.js View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/HTMLScriptElement/script-sync-load-failure.html View 1 chunk +36 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/HTMLScriptElement/script-sync-load-failure-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-26 10:59:14 UTC) #2
eroman
lgtm, thanks!
4 years, 7 months ago (2016-05-26 19:19:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010983002/1
4 years, 7 months ago (2016-05-26 19:21:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 19:27:04 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 19:28:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f654575292abfd9b5b894ec5f3fffd457940fee
Cr-Commit-Position: refs/heads/master@{#396253}

Powered by Google App Engine
This is Rietveld 408576698