Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2010963004: Revert of Make win_clang bot use the lld linker. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make win_clang bot use the lld linker. (patchset #4 id:80001 of https://codereview.chromium.org/1881313002/ ) Reason for revert: Looks like this is much slower than link.exe. Original issue's description: > Make win_clang bot use the lld linker. > > lld can't create .pdb files yet, but win_clang doesn't run any tests, so > that's ok. > > I'd like to check if this improves cycle time, and if so, how much. I might > revert this again in a day or two. > > Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 > > BUG=none > > Committed: https://crrev.com/3aba1a0af10235c54db7253c46525825c1cf2c38 > Cr-Commit-Position: refs/heads/master@{#396205} TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/53d2a33dda162bc63e8d653399bd5f8d307e7363 Cr-Commit-Position: refs/heads/master@{#396260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
Created Revert of Make win_clang bot use the lld linker.
4 years, 6 months ago (2016-05-26 19:46:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010963004/1
4 years, 6 months ago (2016-05-26 19:46:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-26 19:47:19 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/53d2a33dda162bc63e8d653399bd5f8d307e7363 Cr-Commit-Position: refs/heads/master@{#396260}
4 years, 6 months ago (2016-05-26 19:49:43 UTC) #5
Dirk Pranke
4 years, 6 months ago (2016-05-27 22:54:12 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698