Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2010963003: Restart any animations when we allocate a composited layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove test due to flakiness. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index f881a6042a874b94b9ee6295408a6c25b0d0dcb8..6076e8c8a0eb17657e844f3f062a4385b47ff1f5 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -3864,14 +3864,19 @@ IntPoint FrameView::convertFromContainingWidgetToScrollbar(const Scrollbar& scro
return newPoint;
}
+static void setNeedsCompositingUpdate(LayoutViewItem layoutViewItem, CompositingUpdateType updateType)
+{
+ if (PaintLayerCompositor* compositor = !layoutViewItem.isNull() ? layoutViewItem.compositor() : nullptr)
+ compositor->setNeedsCompositingUpdate(updateType);
+}
+
void FrameView::setParentVisible(bool visible)
{
if (isParentVisible() == visible)
return;
// As parent visibility changes, we may need to recomposite this frame view and potentially child frame views.
- if (PaintLayerCompositor* compositor = !layoutViewItem().isNull() ? layoutViewItem().compositor() : nullptr)
- compositor->setNeedsCompositingUpdate(CompositingUpdateRebuildTree);
+ setNeedsCompositingUpdate(layoutViewItem(), CompositingUpdateRebuildTree);
Widget::setParentVisible(visible);
@@ -3886,6 +3891,7 @@ void FrameView::show()
{
if (!isSelfVisible()) {
setSelfVisible(true);
+ setNeedsCompositingUpdate(layoutViewItem(), CompositingUpdateRebuildTree);
updateScrollableAreaSet();
if (isParentVisible()) {
for (const auto& child : m_children)
@@ -3904,6 +3910,7 @@ void FrameView::hide()
child->setParentVisible(false);
}
setSelfVisible(false);
+ setNeedsCompositingUpdate(layoutViewItem(), CompositingUpdateRebuildTree);
updateScrollableAreaSet();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698