third_party/WebKit/LayoutTests/compositing/layer-creation/toggle-animated-iframe-visibility.html - Issue 2010963003: Restart any animations when we allocate a composited layer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/layer-creation/toggle-animated-iframe-visibility.html

Issue 2010963003: Restart any animations when we allocate a composited layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Working on test. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/layer-creation/resources/iframe-spinning-cube.html ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../../resources/run-after-layout-and-paint.js"></script>

	3 <div id="container">

	4 <iframe id="frameContainer" src="./resources/iframe-spinning-cube.html" style= "width: 300px; height: 300px; position: absolute; top: 30px; left: 30px;" frameB order="0"></iframe>

	5 </div>

	6 <script>

	7 window.onload = function() {

	8 if (window.testRunner)

	9 testRunner.waitUntilDone();

	10

	11 runAfterLayoutAndPaint(function() {
	wkorman 2016/05/28 00:59:44 This test reproduces the issue run locally in cont This test reproduces the issue run locally in content shell and observed visually, but is not yet useful with run-webkit-tests. I'm still exploring options. Unfortunately existing animation test infrastructure doesn't look compatible with an animation performed within an iframe, and workarounds to use layer tree text directly show some alternate form of flakiness not yet well understood.
	12 container.style.visibility = 'hidden';

	13 runAfterLayoutAndPaint(function() {

	14 container.style.visibility = 'visible';

	15 runAfterLayoutAndPaint(function() {

	16 if (window.testRunner)

	17 testRunner.notifyDone();

	18 });

	19 });

	20 });

	21 };

	22 </script>

OLD	NEW