Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2010963002: Tidy up MediaStreamSource details. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up MediaStreamSource details. Follow up on r396039, undoing some inconsistencies. R= BUG= Committed: https://crrev.com/7c40527bbc98a82aa01e69cb07057625f5985dc5 Cr-Commit-Position: refs/heads/master@{#396231}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 4 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-26 07:32:06 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-26 07:40:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010963002/1
4 years, 7 months ago (2016-05-26 08:52:23 UTC) #5
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.h: While running git apply --index -3 -p1; error: patch ...
4 years, 7 months ago (2016-05-26 11:35:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010963002/20001
4 years, 7 months ago (2016-05-26 18:10:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 18:16:16 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:17:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c40527bbc98a82aa01e69cb07057625f5985dc5
Cr-Commit-Position: refs/heads/master@{#396231}

Powered by Google App Engine
This is Rietveld 408576698