Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2010953002: Change chromium.memory.fyi to chromium.memory.full (Closed)

Created:
4 years, 7 months ago by benwells
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Change chromium.memory.fyi to chromium.memory.full This master isn't actually an FYI master, it's really an overflow area for the rest of the memory tree. BUG=597178 Committed: https://chromium.googlesource.com/chromium/tools/build/+/ec3e72dd7b0e8a080771bdf8831418804cbe8f40

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : thestig's comment #

Patch Set 4 : Fix file names as well #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -4129 lines) Patch
A + masters/master.chromium.memory.full/Makefile View 0 chunks +-1 lines, --1 lines 0 comments Download
A + masters/master.chromium.memory.full/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + masters/master.chromium.memory.full/buildbot View 0 chunks +-1 lines, --1 lines 0 comments Download
A + masters/master.chromium.memory.full/buildbot.tac View 0 chunks +-1 lines, --1 lines 0 comments Download
A + masters/master.chromium.memory.full/master.cfg View 3 chunks +4 lines, -4 lines 0 comments Download
A + masters/master.chromium.memory.full/master_site_config.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + masters/master.chromium.memory.full/notifier_cfg.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + masters/master.chromium.memory.full/slaves.cfg View 34 chunks +34 lines, -34 lines 0 comments Download
D masters/master.chromium.memory.fyi/Makefile View 1 chunk +0 lines, -5 lines 0 comments Download
D masters/master.chromium.memory.fyi/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D masters/master.chromium.memory.fyi/buildbot View 1 chunk +0 lines, -4 lines 0 comments Download
D masters/master.chromium.memory.fyi/buildbot.tac View 1 chunk +0 lines, -11 lines 0 comments Download
D masters/master.chromium.memory.fyi/master.cfg View 1 chunk +0 lines, -738 lines 0 comments Download
D masters/master.chromium.memory.fyi/master_site_config.py View 1 chunk +0 lines, -14 lines 0 comments Download
D masters/master.chromium.memory.fyi/notifier_cfg.py View 1 chunk +0 lines, -142 lines 0 comments Download
D masters/master.chromium.memory.fyi/slaves.cfg View 1 chunk +0 lines, -284 lines 0 comments Download
M masters/master.chromium/templates/announce.html View 5 chunks +6 lines, -6 lines 0 comments Download
M scripts/master/failures_notifier.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/bot_update.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/gatekeeper.json View 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/gatekeeper_trees.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/builders.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + scripts/slave/recipe_modules/chromium_tests/chromium_memory_full.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_memory_fyi.py View 1 2 3 1 chunk +0 lines, -114 lines 1 comment Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_ChromeOS_MSan_Builder.json View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_MSan_Builder.json View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Chromium_Linux_TSan_Builder.json View 1 2 3 5 chunks +8 lines, -8 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_ChromeOS_MSan_Tests.json View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_MSan_Tests.json View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_memory_full_Linux_TSan_Tests.json View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_ChromeOS_MSan_Builder.json View 1 2 3 1 chunk +0 lines, -441 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_MSan_Builder.json View 1 2 3 1 chunk +0 lines, -441 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Chromium_Linux_TSan_Builder.json View 1 2 3 1 chunk +0 lines, -441 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_ChromeOS_MSan_Tests.json View 1 2 3 1 chunk +0 lines, -455 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_MSan_Tests.json View 1 2 3 1 chunk +0 lines, -455 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_memory_fyi_Linux_TSan_Tests.json View 1 2 3 1 chunk +0 lines, -455 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/msan.json View 1 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/tsan.json View 1 5 chunks +8 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_msan_rel_ng.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_msan_rel_ng.json View 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_tsan_rel_ng.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/masters_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (9 generated)
benwells
+thestig for a first pass. if you want to just send on to dpranke let ...
4 years, 7 months ago (2016-05-26 06:54:35 UTC) #3
Lei Zhang
+dpranke
4 years, 7 months ago (2016-05-26 19:23:58 UTC) #5
Lei Zhang
looks ok to me https://codereview.chromium.org/2010953002/diff/1/scripts/master/failures_notifier.py File scripts/master/failures_notifier.py (right): https://codereview.chromium.org/2010953002/diff/1/scripts/master/failures_notifier.py#newcode39 scripts/master/failures_notifier.py:39: # FailuresNotifiers (e.g. "ordinary" bots ...
4 years, 7 months ago (2016-05-26 19:25:53 UTC) #6
benwells
over to dpranke@ for full review https://codereview.chromium.org/2010953002/diff/1/scripts/master/failures_notifier.py File scripts/master/failures_notifier.py (right): https://codereview.chromium.org/2010953002/diff/1/scripts/master/failures_notifier.py#newcode39 scripts/master/failures_notifier.py:39: # FailuresNotifiers (e.g. ...
4 years, 6 months ago (2016-05-31 08:22:37 UTC) #7
Dirk Pranke
lgtm
4 years, 6 months ago (2016-05-31 20:32:51 UTC) #8
benwells
On 2016/05/31 20:32:51, Dirk Pranke wrote: > lgtm Thanks Dirk! So do I just land ...
4 years, 6 months ago (2016-06-02 01:21:13 UTC) #9
Lei Zhang
I think that's all we do. +oshima (current sheriff) FYI.
4 years, 6 months ago (2016-06-02 01:24:54 UTC) #10
oshima
On 2016/06/02 01:24:54, Lei Zhang (OOO) wrote: > I think that's all we do. +oshima ...
4 years, 6 months ago (2016-06-02 01:27:29 UTC) #11
Dirk Pranke
yup, as long as all of the slaves are auto-rebooting.
4 years, 6 months ago (2016-06-02 01:42:10 UTC) #12
benwells
On 2016/06/02 01:42:10, Dirk Pranke wrote: > yup, as long as all of the slaves ...
4 years, 6 months ago (2016-06-02 01:52:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010953002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010953002/40001
4 years, 6 months ago (2016-06-02 01:52:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/5121)
4 years, 6 months ago (2016-06-02 02:03:06 UTC) #17
benwells
On 2016/06/02 02:03:06, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-02 04:26:14 UTC) #18
Dirk Pranke
still lgtm. https://codereview.chromium.org/2010953002/diff/60001/scripts/slave/recipe_modules/chromium_tests/chromium_memory_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_memory_fyi.py (left): https://codereview.chromium.org/2010953002/diff/60001/scripts/slave/recipe_modules/chromium_tests/chromium_memory_fyi.py#oldcode1 scripts/slave/recipe_modules/chromium_tests/chromium_memory_fyi.py:1: # Copyright 2014 The Chromium Authors. All ...
4 years, 6 months ago (2016-06-02 17:47:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010953002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010953002/60001
4 years, 6 months ago (2016-06-02 23:22:37 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/tools/build/+/ec3e72dd7b0e8a080771bdf8831418804cbe8f40
4 years, 6 months ago (2016-06-02 23:28:44 UTC) #25
benwells
4 years, 6 months ago (2016-06-03 03:55:35 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2032043003/ by benwells@chromium.org.

The reason for reverting is: The master restart script had a problem with this.
Reverting and will reland once troopers have the problems figured out..

Powered by Google App Engine
This is Rietveld 408576698