third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 2010943002: DevTools: Add grouping by Activity to Timeline treeview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2010943002: DevTools: Add grouping by Activity to Timeline treeview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: layout test got resultz Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js » ('j') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index 3ff112863495eb0b711aff902a0662b0fe17a3a6..6740237a44de93698c0821b2984bafa6136c0fbd 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -313,7 +313,7 @@ WebInspector.TimelineUIUtils.interactionPhaseLabel = function(phase)

WebInspector.TimelineUIUtils.isUserFrame = function(frame)

{

- return frame.scriptId !== "0" && !frame.url.startsWith("native ");

+ return frame.scriptId !== "0" && frame.url && !frame.url.startsWith("native ");

caseq 2016/06/15 10:28:09 Also, why this check? Does it work well with eval(

}

/**