Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js

Issue 2010943002: DevTools: Add grouping by Activity to Timeline treeview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js
index 6eeb31caca44b9afb9b1a4cd27fde8fd3adc8a9f..2d7a87cdb18eeee461cd02146bfe4d933d6551aa 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineProfileTree.js
@@ -232,6 +232,7 @@ WebInspector.TimelineAggregator = function(categoryMapper)
*/
WebInspector.TimelineAggregator.GroupBy = {
None: "None",
+ EventName: "EventName",
Category: "Category",
Domain: "Domain",
Subdomain: "Subdomain",
@@ -336,6 +337,7 @@ WebInspector.TimelineAggregator.prototype = {
switch (groupBy) {
case WebInspector.TimelineAggregator.GroupBy.None: return null;
+ case WebInspector.TimelineAggregator.GroupBy.EventName: return node => node.event.name;
alph 2016/05/26 07:23:20 Can event be null? There's a check on the next lin
case WebInspector.TimelineAggregator.GroupBy.Category: return node => node.event ? this._categoryMapper(node.event) : "";
case WebInspector.TimelineAggregator.GroupBy.Subdomain: return groupByDomain.bind(null, false);
case WebInspector.TimelineAggregator.GroupBy.Domain: return groupByDomain.bind(null, true);

Powered by Google App Engine
This is Rietveld 408576698