Break cycles between views, content and webview.

ash/ash.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
     'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/chrome',
   },
   'includes': [
@@ skipping 823 matching lines @@
         '../ui/compositor/compositor.gyp:compositor_test_support',
         '../ui/events/events.gyp:events',
         '../ui/events/events.gyp:events_test_support',
         '../ui/gfx/gfx.gyp:gfx',
         '../ui/gfx/gfx.gyp:gfx_geometry',
         '../ui/keyboard/keyboard.gyp:keyboard',
         '../ui/message_center/message_center.gyp:message_center',
         '../ui/message_center/message_center.gyp:message_center_test_support',
         '../ui/resources/ui_resources.gyp:ui_resources',
         '../ui/ui_unittests.gyp:ui_test_support',
+        '../ui/views/controls/webview/webview_tests.gyp:webview_test_support',
+        '../ui/views/examples/examples.gyp:views_examples_with_content_lib',

[tapted, 2014/03/16 23:45:49]

Having ash_unittests depending on examples.gyp feels a bit odd - how much
explodes if this is just removed? Maybe some transitive dependencies just need
to be moved in here.

[tfarina, 2014/03/17 01:33:09]

I will try removing it and see what happens.

This was added by Harry -
https://chromiumcodereview.appspot.com/10834185/diff/7002/ash/ash.gyp

[Ben Goodger (Google), 2014/03/18 15:59:03]

Should work without it. Only ash_shell needs examples.

[tfarina, 2014/03/19 04:34:18]

Done.

[tfarina, 2014/03/19 14:18:06]

Actually I reverted this change, see below why:

If we remove this dep, then it does not compile:

../../ash/shell/app_list.cc:129: error: undefined reference to
'views::examples::ShowExamplesWindowWithContent(views::examples::Operation,
content::BrowserContext*, aura::Window*)'
../../ash/shell/window_type_launcher.cc:357: error: undefined reference to
'views::examples::ShowExamplesWindowWithContent(views::examples::Operation,
content::BrowserContext*, aura::Window*)'

This is because we are compiling ash/shell files in ash_unittests in order to
support ash/shell/window_watcher_unittest.cc.

If we remove the ash/shell/ files from ash_unittests, then
window_watcher_unittest.cc won't compile (of course).

../../ash/session_state_delegate_stub.cc:51: error: undefined reference to
'ash::shell::CreateLockScreen()'
../../ash/shell/window_watcher_unittest.cc:25: error: undefined reference to
'ash::shell::ShellDelegateImpl::ShellDelegateImpl()'
../../ash/shell/window_watcher_unittest.cc:32: error: undefined reference to
'ash::shell::WindowWatcher::WindowWatcher()'
../../ash/shell/window_watcher_unittest.cc:34: error: undefined reference to
'ash::shell::ShellDelegateImpl::SetWatcher(ash::shell::WindowWatcher*)'
../../ash/shell/window_watcher_unittest.cc:37: error: undefined reference to
'ash::shell::ShellDelegateImpl::SetWatcher(ash::shell::WindowWatcher*)'

I'm happy to address this in a follow up CL though...

         '../ui/views/views.gyp:views',
-        '../ui/views/views.gyp:views_examples_with_content_lib',
         '../ui/views/views.gyp:views_test_support',
-        '../ui/views/views.gyp:views_with_content_test_support',
         '../ui/web_dialogs/web_dialogs.gyp:web_dialogs_test_support',
         '../ui/wm/wm.gyp:wm_core',
         '../url/url.gyp:url_lib',
         'ash_strings.gyp:ash_strings',
         'ash',
         'ash_resources',
         'ash_test_support',
         'ash_with_content',
       ],
       'sources': [
@@ skipping 209 matching lines @@
         '../ui/app_list/app_list.gyp:app_list',
         '../ui/aura/aura.gyp:aura',
         '../ui/base/ui_base.gyp:ui_base',
         '../ui/compositor/compositor.gyp:compositor',
         '../ui/events/events.gyp:events',
         '../ui/gfx/gfx.gyp:gfx',
         '../ui/gfx/gfx.gyp:gfx_geometry',
         '../ui/keyboard/keyboard.gyp:keyboard',
         '../ui/message_center/message_center.gyp:message_center',
         '../ui/resources/ui_resources.gyp:ui_resources',
+        '../ui/views/examples/examples.gyp:views_examples_lib',
+        '../ui/views/examples/examples.gyp:views_examples_with_content_lib',
         '../ui/views/views.gyp:views',
-        '../ui/views/views.gyp:views_examples_lib',
-        '../ui/views/views.gyp:views_examples_with_content_lib',
         '../ui/views/views.gyp:views_test_support',
         'ash',
         'ash_resources',
         'ash_with_content',
       ],
       'sources': [
         'session_state_delegate_stub.cc',
         'session_state_delegate_stub.h',
         'shell/app_list.cc',
         'shell/bubble.cc',
@@ skipping 43 matching lines @@
         }],
         ['chromeos==1', {
           'dependencies': [
             '../device/bluetooth/bluetooth.gyp:device_bluetooth',
           ],
         }],
       ],
     },
   ],
 }