Add a NOTREACHED() to catch users of pre-release NSS.

Add a NOTREACHED() to catch users of pre-release NSS.

Catch a crash for debug build users who followed the
Linux 64bit instructions.

BUG=21454
TEST=debug chrome crashes at NOTREACHED in error
condition using old NSS, skips past in new NSS and
under both conditions in release builds.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25969

[wtc, 2009-09-11 01:26:01]

LGTM.  Thanks!

http://codereview.chromium.org/201086/diff/1/2
File net/base/x509_certificate_nss.cc (right):

http://codereview.chromium.org/201086/diff/1/2#newcode184
Line 184: // 1. run ldd on the chrome executable for NSS's location (ie.
libnss*.so)
Nit: change
   libnss*.so
to
   libnss3.so
or perhaps
   libnss3.so*
because of the .1d suffix added by Debian/Ubuntu.

http://codereview.chromium.org/201086/diff/1/2#newcode185
Line 185: // 2. run ident libnss*.so for the library's version
Same here.

http://codereview.chromium.org/201086/diff/1/2#newcode186
Line 186: NOTREACHED();
It's probably better to just say
  DCHECK(cert_list);
instead of
  if (!cert_list) {
    NOTREACHED();
  }
unless you think it's clearer to put the comment
inside the "if" block.

[chase, 2009-09-11 04:35:05]

http://codereview.chromium.org/201086/diff/1/2
File net/base/x509_certificate_nss.cc (right):

http://codereview.chromium.org/201086/diff/1/2#newcode184
Line 184: // 1. run ldd on the chrome executable for NSS's location (ie.
libnss*.so)
On 2009/09/11 01:26:01, wtc wrote:
> Nit: change
>    libnss*.so
> to
>    libnss3.so
> or perhaps
>    libnss3.so*
> because of the .1d suffix added by Debian/Ubuntu.

Done.

http://codereview.chromium.org/201086/diff/1/2#newcode185
Line 185: // 2. run ident libnss*.so for the library's version
On 2009/09/11 01:26:01, wtc wrote:
> Same here.

Done.

http://codereview.chromium.org/201086/diff/1/2#newcode186
Line 186: NOTREACHED();
On 2009/09/11 01:26:01, wtc wrote:
> It's probably better to just say
>   DCHECK(cert_list);
> instead of
>   if (!cert_list) {
>     NOTREACHED();
>   }
> unless you think it's clearer to put the comment
> inside the "if" block.

Done.

[chase, 2009-09-11 05:20:53]

Committed, though the check-in message refers to NOTREACHED instead of DCHECK. 
A mistake on my part, sorry.  Has anyone changed a Chromium log message
post-commit before?  If we're equipped for it, I'll run it down.

[wtc, 2009-09-11 14:35:17]

LGTM.

I've never changed a commit message.  Not sure if it's
possible.  It's not a big deal though.