Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010853002: Delete //mojo/icu. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -159 lines) Patch
D mojo/icu/BUILD.gn View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/icu/constants.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/icu/generate_icu_constants.py View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/icu/icu.h View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/icu/icu.cc View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-25 22:42:34 UTC) #1
jamesr
Isn't this what implements https://github.com/domokit/mojo/blob/master/mojo/services/icu_data/interfaces/icu_data.mojom ? I see uses of that interface
4 years, 7 months ago (2016-05-25 23:16:30 UTC) #2
viettrungluu
On 2016/05/25 23:16:30, jamesr wrote: > Isn't this what implements > https://github.com/domokit/mojo/blob/master/mojo/services/icu_data/interfaces/icu_data.mojom > ? I ...
4 years, 7 months ago (2016-05-25 23:19:16 UTC) #3
jamesr
Ooh, ok. lgtm
4 years, 7 months ago (2016-05-25 23:21:29 UTC) #4
viettrungluu
4 years, 7 months ago (2016-05-25 23:27:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
88aca057e048862ad6b7ba90aefa80105391752e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698