Cache login identity for NewFTP transactions.

net/url_request/url_request_unittest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_unittest.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 1924 matching lines @@
   EXPECT_TRUE(interceptor.did_cancel_then_restart_main_);
   EXPECT_FALSE(interceptor.did_intercept_final_);
 
   // Check we see a canceled request
   EXPECT_FALSE(req.status().is_success());
   EXPECT_EQ(URLRequestStatus::CANCELED, req.status().status());
 }
 
 class URLRequestTestFTP : public URLRequestTest {
  protected:
+  static FilePath GetDataDir() {
+    FilePath data_dir;
+    PathService::Get(base::DIR_SOURCE_ROOT, &data_dir);
+    data_dir = data_dir.AppendASCII("net");
+    data_dir = data_dir.AppendASCII("data");
+    data_dir = data_dir.AppendASCII("ftp");
+    return data_dir;
+  }
+
   static void SetUpTestCase() {
-    server_ = FTPTestServer::CreateServer(L"");
+    FilePath data_dir;
+    data_dir = data_dir.AppendASCII("net");
+    data_dir = data_dir.AppendASCII("data");
+    data_dir = data_dir.AppendASCII("ftp");
+    server_ = FTPTestServer::CreateServer(data_dir.ToWStringHack(), false);
   }
 
   static void TearDownTestCase() {
     server_ = NULL;
   }
 
   static scoped_refptr<FTPTestServer> server_;
 };
 
 // static
 scoped_refptr<FTPTestServer> URLRequestTestFTP::server_;
 
 TEST_F(URLRequestTestFTP, FTPDirectoryListing) {
   ASSERT_TRUE(NULL != server_.get());
   TestDelegate d;
   {
-    TestURLRequest r(server_->TestServerPage("/"), &d);
+    TestURLRequest r(server_->TestServerPage("/", "chrome", "chrome"), &d);
     r.Start();
     EXPECT_TRUE(r.is_pending());
 
     MessageLoop::current()->Run();
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_LT(0, d.bytes_received());
   }
 }
 
-TEST_F(URLRequestTestFTP, FTPGetTestAnonymous) {
-  ASSERT_TRUE(NULL != server_.get());
-  FilePath app_path;
-  PathService::Get(base::DIR_SOURCE_ROOT, &app_path);
-  app_path = app_path.AppendASCII("LICENSE");
+TEST_F(URLRequestTest, FTPGetTestAnonymous) {
+  FilePath data_dir;
+  data_dir = data_dir.AppendASCII("net");
+  data_dir = data_dir.AppendASCII("data");
+  data_dir = data_dir.AppendASCII("ftp");
+  scoped_refptr<FTPTestServer> server(
+      FTPTestServer::CreateServer(data_dir.ToWStringHack(), true));
+  ASSERT_TRUE(NULL != server.get());
+  FilePath testfile_path(data_dir.AppendASCII("testfile"));
   TestDelegate d;
   {
-    TestURLRequest r(server_->TestServerPage("/LICENSE"), &d);
+    TestURLRequest r(server->TestServerPage("/testfile"), &d);
     r.Start();
     EXPECT_TRUE(r.is_pending());
 
     MessageLoop::current()->Run();
 
     int64 file_size = 0;
-    file_util::GetFileSize(app_path, &file_size);
+    file_util::GetFileSize(testfile_path, &file_size);
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), static_cast<int>(file_size));
   }
 }
 
 TEST_F(URLRequestTestFTP, FTPGetTest) {
   ASSERT_TRUE(NULL != server_.get());
-  FilePath app_path;
-  PathService::Get(base::DIR_SOURCE_ROOT, &app_path);
-  app_path = app_path.AppendASCII("LICENSE");
+  FilePath testfile_path(GetDataDir().AppendASCII("testfile"));
   TestDelegate d;
   {
-    TestURLRequest r(server_->TestServerPage("/LICENSE", "chrome", "chrome"),
+    TestURLRequest r(server_->TestServerPage("/testfile", "chrome", "chrome"),
                      &d);
     r.Start();
     EXPECT_TRUE(r.is_pending());
 
     MessageLoop::current()->Run();
 
     int64 file_size = 0;
-    file_util::GetFileSize(app_path, &file_size);
+    file_util::GetFileSize(testfile_path, &file_size);
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), static_cast<int>(file_size));
   }
 }
 
 TEST_F(URLRequestTestFTP, FTPCheckWrongPassword) {
   ASSERT_TRUE(NULL != server_.get());
-  FilePath app_path;
-  PathService::Get(base::DIR_SOURCE_ROOT, &app_path);
-  app_path = app_path.AppendASCII("LICENSE");
+  FilePath testfile_path(GetDataDir().AppendASCII("testfile"));
   TestDelegate d;
   {
-    TestURLRequest r(server_->TestServerPage("/LICENSE",
+    TestURLRequest r(server_->TestServerPage("/testfile",
                                              "chrome", "wrong_password"), &d);
     r.Start();
     EXPECT_TRUE(r.is_pending());
 
     MessageLoop::current()->Run();
 
     int64 file_size = 0;
-    file_util::GetFileSize(app_path, &file_size);
+    file_util::GetFileSize(testfile_path, &file_size);
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), 0);
   }
 }
 
 TEST_F(URLRequestTestFTP, FTPCheckWrongPasswordRestart) {
   ASSERT_TRUE(NULL != server_.get());
-  FilePath app_path;
-  PathService::Get(base::DIR_SOURCE_ROOT, &app_path);
-  app_path = app_path.AppendASCII("LICENSE");
+  FilePath testfile_path(GetDataDir().AppendASCII("testfile"));
   TestDelegate d;
-  // Set correct login credentials. The delegate will be asked for them when
-  // the initial login with wrong credentials will fail.
+  // Set correct login identity. The delegate will be asked for it when
+  // the initial login with wrong password will fail.
   d.set_username(L"chrome");
   d.set_password(L"chrome");
   {
-    TestURLRequest r(server_->TestServerPage("/LICENSE",
+    TestURLRequest r(server_->TestServerPage("/testfile",
                                              "chrome", "wrong_password"), &d);
     r.Start();
     EXPECT_TRUE(r.is_pending());
 
     MessageLoop::current()->Run();
 
     int64 file_size = 0;
-    file_util::GetFileSize(app_path, &file_size);
+    file_util::GetFileSize(testfile_path, &file_size);
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), static_cast<int>(file_size));
   }
 }
 
 TEST_F(URLRequestTestFTP, FTPCheckWrongUser) {
   ASSERT_TRUE(NULL != server_.get());
-  FilePath app_path;
-  PathService::Get(base::DIR_SOURCE_ROOT, &app_path);
-  app_path = app_path.AppendASCII("LICENSE");
+  FilePath testfile_path(GetDataDir().AppendASCII("testfile"));
   TestDelegate d;
   {
-    TestURLRequest r(server_->TestServerPage("/LICENSE",
+    TestURLRequest r(server_->TestServerPage("/testfile",
                                              "wrong_user", "chrome"), &d);
     r.Start();
     EXPECT_TRUE(r.is_pending());
 
     MessageLoop::current()->Run();
 
     int64 file_size = 0;
-    file_util::GetFileSize(app_path, &file_size);
+    file_util::GetFileSize(testfile_path, &file_size);
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), 0);
   }
 }
 
 TEST_F(URLRequestTestFTP, FTPCheckWrongUserRestart) {
   ASSERT_TRUE(NULL != server_.get());
-  FilePath app_path;
-  PathService::Get(base::DIR_SOURCE_ROOT, &app_path);
-  app_path = app_path.AppendASCII("LICENSE");
+  FilePath testfile_path(GetDataDir().AppendASCII("testfile"));
   TestDelegate d;
-  // Set correct login credentials. The delegate will be asked for them when
-  // the initial login with wrong credentials will fail.
+  // Set correct login identity. The delegate will be asked for it when
+  // the initial login with wrong user will fail.
   d.set_username(L"chrome");
   d.set_password(L"chrome");
   {
-    TestURLRequest r(server_->TestServerPage("/LICENSE",
+    TestURLRequest r(server_->TestServerPage("/testfile",
                                              "wrong_user", "chrome"), &d);
     r.Start();
     EXPECT_TRUE(r.is_pending());
 
     MessageLoop::current()->Run();
 
     int64 file_size = 0;
-    file_util::GetFileSize(app_path, &file_size);
+    file_util::GetFileSize(testfile_path, &file_size);
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), static_cast<int>(file_size));
   }
 }
+
+TEST_F(URLRequestTestFTP, FTPCacheURLIdentity) {
+  ASSERT_TRUE(NULL != server_.get());
+  FilePath testfile_path(GetDataDir().AppendASCII("testfile"));
+
+  scoped_refptr<URLRequestTestContext> context(new URLRequestTestContext);
+
+  scoped_ptr<TestDelegate> d(new TestDelegate);
+  {
+    // Pass correct identity in the URL. It should be cached.
+    TestURLRequest r(server_->TestServerPage("/testfile", "chrome", "chrome"),
+                     d.get());
+    r.set_context(context.get());
+    r.Start();
+    EXPECT_TRUE(r.is_pending());
+
+    MessageLoop::current()->Run();
+
+    int64 file_size = 0;
+    file_util::GetFileSize(testfile_path, &file_size);
+
+    EXPECT_FALSE(r.is_pending());
+    EXPECT_EQ(1, d->response_started_count());
+    EXPECT_FALSE(d->received_data_before_response());
+    EXPECT_EQ(d->bytes_received(), static_cast<int>(file_size));
+  }
+
+  // Use a new delegate without explicit identity. The cached one should be
+  // used.
+  d.reset(new TestDelegate);
+  {
+    // Don't pass identity in the URL, it would override valid cached one.
+    TestURLRequest r(server_->TestServerPage("/testfile"), d.get());
+    r.set_context(context.get());
+    r.Start();
+    EXPECT_TRUE(r.is_pending());
+
+    MessageLoop::current()->Run();
+
+    int64 file_size = 0;
+    file_util::GetFileSize(testfile_path, &file_size);
+
+    EXPECT_FALSE(r.is_pending());
+    EXPECT_EQ(1, d->response_started_count());
+    EXPECT_FALSE(d->received_data_before_response());
+    EXPECT_EQ(d->bytes_received(), static_cast<int>(file_size));
+  }
+}
+
+TEST_F(URLRequestTestFTP, FTPCacheLoginBoxIdentity) {
+  ASSERT_TRUE(NULL != server_.get());
+  FilePath testfile_path(GetDataDir().AppendASCII("testfile"));
+
+  scoped_refptr<URLRequestTestContext> context(new URLRequestTestContext);
+
+  scoped_ptr<TestDelegate> d(new TestDelegate);
+  // Set correct login identity. The delegate will be asked for it when
+  // the initial login with wrong password will fail.
+  d->set_username(L"chrome");
+  d->set_password(L"chrome");
+  {
+    TestURLRequest r(server_->TestServerPage("/testfile",
+                                             "chrome", "wrong_password"),
+                     d.get());
+    r.set_context(context.get());
+    r.Start();
+    EXPECT_TRUE(r.is_pending());
+
+    MessageLoop::current()->Run();
+
+    int64 file_size = 0;
+    file_util::GetFileSize(testfile_path, &file_size);
+
+    EXPECT_FALSE(r.is_pending());
+    EXPECT_EQ(1, d->response_started_count());
+    EXPECT_FALSE(d->received_data_before_response());
+    EXPECT_EQ(d->bytes_received(), static_cast<int>(file_size));
+  }
+
+  // Use a new delegate without explicit identity. The cached one should be
+  // used.
+  d.reset(new TestDelegate);
+  {
+    // Don't pass identity in the URL, it would override valid cached one.
+    TestURLRequest r(server_->TestServerPage("/testfile"), d.get());
+    r.set_context(context.get());
+    r.Start();
+    EXPECT_TRUE(r.is_pending());
+
+    MessageLoop::current()->Run();
+
+    int64 file_size = 0;
+    file_util::GetFileSize(testfile_path, &file_size);
+
+    EXPECT_FALSE(r.is_pending());
+    EXPECT_EQ(1, d->response_started_count());
+    EXPECT_FALSE(d->received_data_before_response());
+    EXPECT_EQ(d->bytes_received(), static_cast<int>(file_size));
+  }
+}