Chromium Code Reviews| Index: content/test/data/android/input/input_forms.html |
| diff --git a/content/test/data/android/input/input_forms.html b/content/test/data/android/input/input_forms.html |
| index 6e1c35147391812b4c242a5985b09aed3fb1c505..973e6e974aaea1f60355bc8e354d58586c1bd287 100644 |
| --- a/content/test/data/android/input/input_forms.html |
| +++ b/content/test/data/android/input/input_forms.html |
| @@ -31,7 +31,10 @@ var mutationObserver = new MutationObserver(function(mutations) { |
| }); |
| }) |
| -var mutationConfig = { attributes: false, childList: false, chracterData: true }; |
| +// If |childList| is false, only the first observed element will be observed. I.E., the events we |
| +// get are only from |inputText|, not from |contenteditableEvent|. This should be investigated |
| +// in the future. |
|
Changwan Ryu
2016/05/26 07:38:09
I don't understand this part. Do we ever get any m
|
| +var mutationConfig = { attributes: false, childList: true, chracterData: true }; |
|
Changwan Ryu
2016/05/26 07:38:09
did you try different combinations for input and c
|
| function addEventLog(type, detail) { |
| if (log.length > 0) { |
| @@ -56,7 +59,7 @@ function addKeyEventListener(element, event_name) { |
| element.addEventListener(event_name, function (e) { addEventLog(event_name, e.keyCode); }); |
| } |
| -function addSelectionEventListener(element, event_name) { |
| +function addSelectionEventListener(event_name) { |
| // Note that listeners added to the element are not effective for now. |
| document.addEventListener(event_name, function (e) { addEventLog(event_name, e.data); }); |
| } |
| @@ -73,12 +76,16 @@ function registerListenersAndObserver(element) { |
| addEventListener(element, "select"); |
| addEventListener(element, "change"); |
| addEventListener(element, "input"); |
| - addSelectionEventListener(element, "selectionchange"); |
| mutationObserver.observe(element, mutationConfig); |
| } |
| +var inputText = document.getElementById("input_text"); |
| var contenteditableEvent = document.getElementById("contenteditable_event"); |
| +// SelectionEventListener should be outside registerListenersAndObserver() to avoid duplication. |
| +addSelectionEventListener("selectionchange"); |
| + |
| +registerListenersAndObserver(inputText); |
| registerListenersAndObserver(contenteditableEvent); |
| </script> |