Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2010803003: elf_reader: drop unused zlib include (Closed)

Created:
4 years, 7 months ago by vapier
Modified:
4 years, 7 months ago
Reviewers:
yunlian, ivanpe
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

elf_reader: drop unused zlib include This breaks building for targets that don't include zlib. BUG=chromium:604440 R=ivanpe@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/6368037ef21c46e06a0d2094777764dd3959817d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/common/dwarf/elf_reader.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
vapier
4 years, 7 months ago (2016-05-25 20:08:22 UTC) #2
ivanpe
On 2016/05/25 20:08:22, vapier wrote: LGTM
4 years, 7 months ago (2016-05-25 20:35:04 UTC) #3
vapier
4 years, 7 months ago (2016-05-25 20:38:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6368037ef21c46e06a0d2094777764dd3959817d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698