Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2010793003: Clean up media header include guards (Closed)

Created:
4 years, 7 months ago by watk
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, avayvod+watch_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, eme-reviews_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-media_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up media header include guards All media headers now have correct and matching include guards. BUG=none Committed: https://crrev.com/bf212a6ca1f43e06d29531d39fb86c844a7e0c7d Cr-Commit-Position: refs/heads/master@{#396865}

Patch Set 1 : #

Patch Set 2 : Update references to the param traits guard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -210 lines) Patch
M media/audio/cras/cras_unified.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/android/provision_fetcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/audio_buffer_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/audio_shifter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/audio_splicer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_timestamp_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/fake_single_thread_task_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/fake_text_track_stream.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/base/ipc/media_param_traits.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/ipc/media_param_traits.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M media/base/ipc/media_param_traits_macros.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/media_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/null_video_sink.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/sample_format.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/test_random.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/text_track_config.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/lru.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/resource_multibuffer_data_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_cast_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/content/animated_content_sampler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/content/capture_resolution_chooser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/content/feedback_signal_accumulator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/content/screen_capture_device_core.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/content/smooth_event_sampler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/android/video_capture_device_factory_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/fake_video_capture_device.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/fake_video_capture_device_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/file_video_capture_device.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/file_video_capture_device_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/linux/v4l2_capture_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/linux/video_capture_device_chromeos.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/linux/video_capture_device_factory_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/linux/video_capture_device_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/mac/video_capture_device_decklink_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/mac/video_capture_device_factory_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/mac/video_capture_device_mac.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/video_capture_device.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/video_capture_device_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/video_capture_device_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/capability_list_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/filter_base_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/pin_base_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/sink_filter_observer_win.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/sink_filter_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/sink_input_pin_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/video_capture_device_mf_win.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/capture/video/win/video_capture_device_win.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/common/mod_util.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/net/rtcp/receiver_rtcp_event_subscriber.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/net/rtcp/rtcp_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/net/rtcp/test_rtcp_packet_builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/net/rtp/packet_storage.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/net/rtp/rtp_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/receiver/cast_receiver_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/congestion_control.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/sender/vp8_encoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/test/skewed_single_thread_task_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/test/skewed_tick_clock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/test/utility/in_process_receiver.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/test/utility/input_builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/test/utility/net_utility.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/cast/test/utility/test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/test/utility/video_utility.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/cdm/aes_decryptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/filters/vp9_raw_bits_reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/formats/mp2t/es_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp2t/es_parser_adts.h View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp2t/es_parser_h264.h View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp2t/mp2t_common.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp2t/ts_packet.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp2t/ts_section.h View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp2t/ts_section_pat.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp2t/ts_section_pes.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp2t/ts_section_pmt.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp2t/ts_section_psi.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/formats/mp4/bitstream_converter.h View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/webm/webm_crypto_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/avda_state_provider.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/gpu/vt_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/services/media_mojo_export.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
watk
I noticed that avda_state_provider had the wrong guard, and then I noticed some others, and ...
4 years, 7 months ago (2016-05-26 01:54:33 UTC) #3
DaleCurtis
lgtm, would be great as a chrome wide presubmit if it could be made robust.
4 years, 6 months ago (2016-05-26 18:24:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010793003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010793003/20001
4 years, 6 months ago (2016-05-26 18:31:24 UTC) #6
watk
inferno@chromium.org: Please review changes in media/ipc.
4 years, 6 months ago (2016-05-26 18:32:17 UTC) #8
watk
media/base/ipc actually, thanks.
4 years, 6 months ago (2016-05-26 18:32:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/72431)
4 years, 6 months ago (2016-05-26 18:42:38 UTC) #11
inferno
4 years, 6 months ago (2016-05-27 05:34:54 UTC) #13
Tom Sepez
Param traits LGTM
4 years, 6 months ago (2016-05-27 16:56:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010793003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010793003/40001
4 years, 6 months ago (2016-05-31 16:38:03 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-05-31 18:14:36 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 18:15:50 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf212a6ca1f43e06d29531d39fb86c844a7e0c7d
Cr-Commit-Position: refs/heads/master@{#396865}

Powered by Google App Engine
This is Rietveld 408576698