Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2010783004: [mojo-edk] Revert port reservation timeout behavior (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Revert port reservation timeout behavior This was a bad idea and it makes debugging harder. Rather than increase the timeout, this reverts the behavior altogether. We can add an embedder API to explicitly signal process death in the future. BUG=612844 R=amistry@chromium.org Committed: https://crrev.com/2e82ffbd8d4dcf137b893f03edd945fff4a03f9a Cr-Commit-Position: refs/heads/master@{#396103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M mojo/edk/system/node_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/node_controller.cc View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
4 years, 6 months ago (2016-05-26 00:39:43 UTC) #1
Anand Mistry (off Chromium)
lgtm
4 years, 6 months ago (2016-05-26 00:41:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010783004/1
4 years, 6 months ago (2016-05-26 00:42:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-26 03:37:48 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 03:39:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e82ffbd8d4dcf137b893f03edd945fff4a03f9a
Cr-Commit-Position: refs/heads/master@{#396103}

Powered by Google App Engine
This is Rietveld 408576698