Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2010783003: Remove linked_ptr in cloud print code. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@privet
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove linked_ptr in cloud print code. BUG=556939 Committed: https://crrev.com/d1b22fc961b1a2677c32f61a2a5640850b66adb9 Cr-Commit-Position: refs/heads/master@{#396308}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Patch Set 3 : More like original code #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -108 lines) Patch
M chrome/browser/local_discovery/service_discovery_client_impl.h View 10 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_impl.cc View 1 2 15 chunks +66 lines, -88 lines 3 comments Download
M chrome/browser/printing/cloud_print/privet_local_printer_lister.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_local_printer_lister.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-05-26 19:20:23 UTC) #2
Vitaly Buka (NO REVIEWS)
LGTM with few nits. https://codereview.chromium.org/2010783003/diff/1/chrome/browser/local_discovery/service_discovery_client_impl.cc File chrome/browser/local_discovery/service_discovery_client_impl.cc (left): https://codereview.chromium.org/2010783003/diff/1/chrome/browser/local_discovery/service_discovery_client_impl.cc#oldcode248 chrome/browser/local_discovery/service_discovery_client_impl.cc:248: std::pair<ServiceListenersMap::iterator, bool> found = services_.insert( ...
4 years, 7 months ago (2016-05-26 19:37:18 UTC) #3
Lei Zhang
https://codereview.chromium.org/2010783003/diff/1/chrome/browser/local_discovery/service_discovery_client_impl.cc File chrome/browser/local_discovery/service_discovery_client_impl.cc (left): https://codereview.chromium.org/2010783003/diff/1/chrome/browser/local_discovery/service_discovery_client_impl.cc#oldcode248 chrome/browser/local_discovery/service_discovery_client_impl.cc:248: std::pair<ServiceListenersMap::iterator, bool> found = services_.insert( On 2016/05/26 19:37:17, Vitaly ...
4 years, 7 months ago (2016-05-26 20:31:57 UTC) #4
Vitaly Buka (NO REVIEWS)
lgtm I like No. 3.
4 years, 7 months ago (2016-05-26 21:20:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010783003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010783003/40001
4 years, 7 months ago (2016-05-26 21:21:39 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-26 23:06:00 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d1b22fc961b1a2677c32f61a2a5640850b66adb9 Cr-Commit-Position: refs/heads/master@{#396308}
4 years, 7 months ago (2016-05-26 23:08:02 UTC) #10
limasdf
https://codereview.chromium.org/2010783003/diff/40001/chrome/browser/local_discovery/service_discovery_client_impl.cc File chrome/browser/local_discovery/service_discovery_client_impl.cc (right): https://codereview.chromium.org/2010783003/diff/40001/chrome/browser/local_discovery/service_discovery_client_impl.cc#newcode231 chrome/browser/local_discovery/service_discovery_client_impl.cc:231: set_has_srv(!!record); Hi Lei, Is this intended? !!(double exclamation)
4 years, 7 months ago (2016-05-26 23:17:26 UTC) #12
Lei Zhang
https://codereview.chromium.org/2010783003/diff/40001/chrome/browser/local_discovery/service_discovery_client_impl.cc File chrome/browser/local_discovery/service_discovery_client_impl.cc (right): https://codereview.chromium.org/2010783003/diff/40001/chrome/browser/local_discovery/service_discovery_client_impl.cc#newcode231 chrome/browser/local_discovery/service_discovery_client_impl.cc:231: set_has_srv(!!record); On 2016/05/26 23:17:26, limasdf wrote: > Hi Lei, ...
4 years, 7 months ago (2016-05-26 23:19:46 UTC) #13
limasdf
4 years, 7 months ago (2016-05-27 01:12:00 UTC) #14
Message was sent while issue was closed.
Oops. I forgot to press 'publish. Thanks Lei!

https://codereview.chromium.org/2010783003/diff/40001/chrome/browser/local_di...
File chrome/browser/local_discovery/service_discovery_client_impl.cc (right):

https://codereview.chromium.org/2010783003/diff/40001/chrome/browser/local_di...
chrome/browser/local_discovery/service_discovery_client_impl.cc:231:
set_has_srv(!!record);
On 2016/05/26 23:19:46, Lei Zhang wrote:
> On 2016/05/26 23:17:26, limasdf wrote:
> > Hi Lei,
> > 
> > Is this intended? !!(double exclamation)
> 
> Yes, it's just another way of writing "record != NULL". MSVC complains if one
> tries to pass in a pointer to a function that takes a bool, so this has to be
a
> comparison of some kind.

I see. thanks for the explain & sorry for my ignorance .

Powered by Google App Engine
This is Rietveld 408576698