Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010773002: [DevTools] Draw screen border below screen image when taking screenshot. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Draw screen border below screen image when taking screenshot. BUG=613515 Committed: https://crrev.com/5a8e343e823740a06acf460131d08dd6f655119b Cr-Commit-Position: refs/heads/master@{#396056}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 3 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-05-25 17:48:43 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2010773002/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js (right): https://codereview.chromium.org/2010773002/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js#newcode413 third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js:413: if (error) let's do console.error here - ignoring ...
4 years, 7 months ago (2016-05-25 18:16:58 UTC) #3
dgozman
https://codereview.chromium.org/2010773002/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js (right): https://codereview.chromium.org/2010773002/diff/1/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js#newcode413 third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js:413: if (error) On 2016/05/25 18:16:58, lushnikov wrote: > let's ...
4 years, 7 months ago (2016-05-25 20:23:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010773002/20001
4 years, 7 months ago (2016-05-25 20:23:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/228183)
4 years, 7 months ago (2016-05-25 22:25:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010773002/20001
4 years, 7 months ago (2016-05-25 22:30:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 00:36:11 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 00:38:06 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5a8e343e823740a06acf460131d08dd6f655119b
Cr-Commit-Position: refs/heads/master@{#396056}

Powered by Google App Engine
This is Rietveld 408576698