Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2010753002: views: Remove dead code. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Remove dead code. GetDisplaysFromWindow() is no longer used after https://crrev.com/389154, since mash/wm uses ScreenMus to get the list of displays. So remove this code. BUG=603316 Committed: https://crrev.com/abb78be10d93db163dec7a1add73abaed512c362 Cr-Commit-Position: refs/heads/master@{#395924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M mash/wm/window_manager_application.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/views/mus/display_converter.h View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/views/mus/display_converter.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sadrul
4 years, 6 months ago (2016-05-25 15:16:47 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-05-25 15:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010753002/1
4 years, 6 months ago (2016-05-25 16:16:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-25 17:27:52 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 17:28:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abb78be10d93db163dec7a1add73abaed512c362
Cr-Commit-Position: refs/heads/master@{#395924}

Powered by Google App Engine
This is Rietveld 408576698