Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2010743002: PPC: [build] Fix a clang warning (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [build] Fix a clang warning Port a23222ed32d8a4829af1dc33f93ca599fef6c50a Original commit message: For cross-compiler-compatibility and standards compliance %p requires a void*, rather than any pointer type. R=machenbach@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:474921 LOG=N Committed: https://crrev.com/4a4f2537a30b5bd6451eb256ddcb892dc600af08 Cr-Commit-Position: refs/heads/master@{#36522}

Patch Set 1 #

Patch Set 2 : another catch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/s390/simulator-s390.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M test/cctest/test-assembler-s390.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
john.yan
PTAL
4 years, 6 months ago (2016-05-25 14:46:17 UTC) #1
JoranSiu
On 2016/05/25 14:46:17, john.yan wrote: > PTAL lgtm
4 years, 6 months ago (2016-05-25 14:48:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010743002/20001
4 years, 6 months ago (2016-05-25 14:58:11 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-25 15:28:06 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4a4f2537a30b5bd6451eb256ddcb892dc600af08 Cr-Commit-Position: refs/heads/master@{#36522}
4 years, 6 months ago (2016-05-25 15:29:25 UTC) #7
Michael Achenbach
4 years, 6 months ago (2016-05-27 06:56:09 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698