Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2010693003: [test] add debugger tests for debug evaluation in async functions (Closed)

Created:
4 years, 7 months ago by caitp (gmail)
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] add debugger tests for debug evaluation in async functions BUG=v8:4483 R=littledan@chromium.org, yangguo@chromium.org Committed: https://crrev.com/f30f8286fbed894bf0f80ae0efd9acca9e7e5eec Cr-Commit-Position: refs/heads/master@{#36614}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -0 lines) Patch
A test/mjsunit/harmony/async-function-debug-evaluate.js View 1 chunk +139 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
caitp (gmail)
PTAL, more debugger tests
4 years, 7 months ago (2016-05-25 19:05:38 UTC) #1
Dan Ehrenberg
lgtm https://codereview.chromium.org/2010693003/diff/1/test/mjsunit/harmony/async-function-debug-evaluate.js File test/mjsunit/harmony/async-function-debug-evaluate.js (right): https://codereview.chromium.org/2010693003/diff/1/test/mjsunit/harmony/async-function-debug-evaluate.js#newcode134 test/mjsunit/harmony/async-function-debug-evaluate.js:134: }). Optional style nit: I think it's a ...
4 years, 6 months ago (2016-05-27 09:49:25 UTC) #2
Yang
On 2016/05/27 09:49:25, Dan Ehrenberg wrote: > lgtm > > https://codereview.chromium.org/2010693003/diff/1/test/mjsunit/harmony/async-function-debug-evaluate.js > File test/mjsunit/harmony/async-function-debug-evaluate.js (right): ...
4 years, 6 months ago (2016-05-30 09:36:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010693003/1
4 years, 6 months ago (2016-05-31 13:47:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 14:13:49 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 14:14:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f30f8286fbed894bf0f80ae0efd9acca9e7e5eec
Cr-Commit-Position: refs/heads/master@{#36614}

Powered by Google App Engine
This is Rietveld 408576698